From 5c8456524af5b73c706f65146681a6bc268d1b5c Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 30 Jan 2025 15:17:08 +0000 Subject: [PATCH 1/7] Update 7723 to include EELS/EEST in CFI --- EIPS/eip-7723.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index 3ef40b5329b134..b8a077cfc4e371 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -57,6 +57,10 @@ Non-Core EIPs that are `Considered for Inclusion` **SHOULD** be supported prior An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. +An EIP **MUST** have an implementation in [execution-specs](https://github.com/ethereum/execution-specs) in an open PR to or merged to before it can be moved to this stage. + +An EIP **MUST** have an implementation of its tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests) in an open PR to or merged to before it can be moved to this stage. + ### Declined for Inclusion At any time during the network upgrade planning process, client developers **MAY** move EIPs from any other stage to the `Declined for Inclusion` stage if client teams are against including the EIP in the network upgrade. Once a decision is made by client teams to move an EIP to `Declined for Inclusion`, the Upgrade Meta EIP **SHOULD** be updated to reflect this. From d20d9b582a8c162f15194ea17566389a0c8fb5fc Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 30 Jan 2025 21:37:35 +0000 Subject: [PATCH 2/7] suggestions --- EIPS/eip-7723.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index b8a077cfc4e371..4819295f5bedd5 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -57,9 +57,11 @@ Non-Core EIPs that are `Considered for Inclusion` **SHOULD** be supported prior An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. -An EIP **MUST** have an implementation in [execution-specs](https://github.com/ethereum/execution-specs) in an open PR to or merged to before it can be moved to this stage. +An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs) in an open PR. -An EIP **MUST** have an implementation of its tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests) in an open PR to or merged to before it can be moved to this stage. +An EIP **SHOULD** have tests implemented in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests) in an open PR. + +The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. ### Declined for Inclusion @@ -71,6 +73,10 @@ At any time during the network upgrade planning process, client developers **MAY When client teams agree to implement a Core EIP in the **next** Upgrade Devnet, the EIP **SHOULD** move to the `Scheduled for Inclusion` stage, and the Upgrade Meta EIP **SHOULD** be updated to reflect this. Non-Core EIPs **SHOULD** move to `Scheduled for Inclusion` when client teams agree to immediately prioritize their implementation. +An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs) merged to the `devnets/upgradeName/version` branch of the repository before it can be moved to this stage. + +An EIP **MUST** have tests implemented in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests) and merged to the `main` branch of the repository before it can be moved to this stage. + `Scheduled for Inclusion` signals that implementation and testing work are underway. The EIP **SHOULD** be included in the network upgrade if no issues arise. The latest Upgrade Devnet must contain all `Scheduled for Inclusion` Core EIPs. An EIP **MAY** be moved from `Scheduled for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. An EIP **MAY** also be moved from `Scheduled for Inclusion` to `Considered for Inclusion` if client teams are in favor of including the EIP in the network upgrade but cannot commit to including it in the **next** Upgrade Devnet. From 1c3fd5de1291d5e736f3816b4fbfa84daf6cd21f Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Wed, 12 Feb 2025 22:39:35 +0000 Subject: [PATCH 3/7] Paraphrasing --- EIPS/eip-7723.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index 4819295f5bedd5..a8f0aacefa8b97 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -57,11 +57,7 @@ Non-Core EIPs that are `Considered for Inclusion` **SHOULD** be supported prior An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. -An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs) in an open PR. - -An EIP **SHOULD** have tests implemented in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests) in an open PR. - -The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. +An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. ### Declined for Inclusion From d38d9a6a7a9f7d4c98c181f6c598c50ac2e51857 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 13 Feb 2025 15:45:35 +0000 Subject: [PATCH 4/7] ACD comments --- EIPS/eip-7723.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index a8f0aacefa8b97..e1aa68f90c6db0 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -57,7 +57,7 @@ Non-Core EIPs that are `Considered for Inclusion` **SHOULD** be supported prior An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. -An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. +An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/78fb726158c69d8fa164e28f195fabf6ab59b915), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/7cbf9fb9d52a2221f92f4d3cff39ea59aa37b4d3), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. ### Declined for Inclusion @@ -69,9 +69,7 @@ At any time during the network upgrade planning process, client developers **MAY When client teams agree to implement a Core EIP in the **next** Upgrade Devnet, the EIP **SHOULD** move to the `Scheduled for Inclusion` stage, and the Upgrade Meta EIP **SHOULD** be updated to reflect this. Non-Core EIPs **SHOULD** move to `Scheduled for Inclusion` when client teams agree to immediately prioritize their implementation. -An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs) merged to the `devnets/upgradeName/version` branch of the repository before it can be moved to this stage. - -An EIP **MUST** have tests implemented in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests) and merged to the `main` branch of the repository before it can be moved to this stage. +An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/78fb726158c69d8fa164e28f195fabf6ab59b915), submitted as an open PR or merged to the `devnets/upgradeName/version` branch of the repository, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/7cbf9fb9d52a2221f92f4d3cff39ea59aa37b4d3), also submitted as an open PR or merged to the `main` branch of the repository. Client developers **MAY** decide to allow an EIP to be moved to `Scheduled for Inclusion` without an [execution-specs](https://github.com/ethereum/execution-specs/tree/78fb726158c69d8fa164e28f195fabf6ab59b915) implementation, but the tests are strictly mandatory. `Scheduled for Inclusion` signals that implementation and testing work are underway. The EIP **SHOULD** be included in the network upgrade if no issues arise. The latest Upgrade Devnet must contain all `Scheduled for Inclusion` Core EIPs. From 48984480a83770f80caf8f5bfc016bb4c4de6128 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 13 Feb 2025 17:33:02 +0000 Subject: [PATCH 5/7] fix links --- EIPS/eip-7723.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index e1aa68f90c6db0..a65e48e66498ef 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -57,7 +57,7 @@ Non-Core EIPs that are `Considered for Inclusion` **SHOULD** be supported prior An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. -An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/78fb726158c69d8fa164e28f195fabf6ab59b915), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/7cbf9fb9d52a2221f92f4d3cff39ea59aa37b4d3), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. +An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/master/README.md), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/main/README.md), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. ### Declined for Inclusion @@ -69,7 +69,7 @@ At any time during the network upgrade planning process, client developers **MAY When client teams agree to implement a Core EIP in the **next** Upgrade Devnet, the EIP **SHOULD** move to the `Scheduled for Inclusion` stage, and the Upgrade Meta EIP **SHOULD** be updated to reflect this. Non-Core EIPs **SHOULD** move to `Scheduled for Inclusion` when client teams agree to immediately prioritize their implementation. -An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/78fb726158c69d8fa164e28f195fabf6ab59b915), submitted as an open PR or merged to the `devnets/upgradeName/version` branch of the repository, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/7cbf9fb9d52a2221f92f4d3cff39ea59aa37b4d3), also submitted as an open PR or merged to the `main` branch of the repository. Client developers **MAY** decide to allow an EIP to be moved to `Scheduled for Inclusion` without an [execution-specs](https://github.com/ethereum/execution-specs/tree/78fb726158c69d8fa164e28f195fabf6ab59b915) implementation, but the tests are strictly mandatory. +An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/master/README.md), submitted as an open PR or merged to the `devnets/upgradeName/version` branch of the repository, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/main/README.md), also submitted as an open PR or merged to the `main` branch of the repository. Client developers **MAY** decide to allow an EIP to be moved to `Scheduled for Inclusion` without an [execution-specs](https://github.com/ethereum/execution-specs/tree/master/README.md) implementation, but the tests are strictly mandatory. `Scheduled for Inclusion` signals that implementation and testing work are underway. The EIP **SHOULD** be included in the network upgrade if no issues arise. The latest Upgrade Devnet must contain all `Scheduled for Inclusion` Core EIPs. From a39a049c3c5027bfa63d53279f5042cae8fd52ab Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 13 Feb 2025 17:49:07 +0000 Subject: [PATCH 6/7] fix links 2 --- EIPS/eip-7723.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index a65e48e66498ef..14696078ac33f6 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -57,7 +57,7 @@ Non-Core EIPs that are `Considered for Inclusion` **SHOULD** be supported prior An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. -An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/master/README.md), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/main/README.md), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. +An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/blob/38621dc8f2cbc80a096e0906b28e4d4984752501/README.md), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. ### Declined for Inclusion @@ -69,7 +69,7 @@ At any time during the network upgrade planning process, client developers **MAY When client teams agree to implement a Core EIP in the **next** Upgrade Devnet, the EIP **SHOULD** move to the `Scheduled for Inclusion` stage, and the Upgrade Meta EIP **SHOULD** be updated to reflect this. Non-Core EIPs **SHOULD** move to `Scheduled for Inclusion` when client teams agree to immediately prioritize their implementation. -An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/tree/master/README.md), submitted as an open PR or merged to the `devnets/upgradeName/version` branch of the repository, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/tree/main/README.md), also submitted as an open PR or merged to the `main` branch of the repository. Client developers **MAY** decide to allow an EIP to be moved to `Scheduled for Inclusion` without an [execution-specs](https://github.com/ethereum/execution-specs/tree/master/README.md) implementation, but the tests are strictly mandatory. +An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md), submitted as an open PR or merged to the `devnets/upgradeName/version` branch of the repository, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/blob/38621dc8f2cbc80a096e0906b28e4d4984752501/README.md), also submitted as an open PR or merged to the `main` branch of the repository. Client developers **MAY** decide to allow an EIP to be moved to `Scheduled for Inclusion` without an [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md) implementation, but the tests are strictly mandatory. `Scheduled for Inclusion` signals that implementation and testing work are underway. The EIP **SHOULD** be included in the network upgrade if no issues arise. The latest Upgrade Devnet must contain all `Scheduled for Inclusion` Core EIPs. From d67d3b197a82ff2379df4d4aaffd31fba8bb318b Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Mon, 24 Feb 2025 18:39:01 +0000 Subject: [PATCH 7/7] EIP updates --- EIPS/eip-7723.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/EIPS/eip-7723.md b/EIPS/eip-7723.md index 14696078ac33f6..e2a261e054dd57 100644 --- a/EIPS/eip-7723.md +++ b/EIPS/eip-7723.md @@ -59,6 +59,8 @@ An EIP **MAY** be moved from `Considered for Inclusion` to `Declined for Inclusi An EIP **SHOULD** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md), submitted as an open PR, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/blob/38621dc8f2cbc80a096e0906b28e4d4984752501/README.md), also submitted as an open PR. The EIP writer is encouraged to reach out to the maintainers of both repositories for assistance with implementation. Client developers **MAY** decide to allow an EIP to be moved to `Considered for Inclusion` without either implementation, being aware that the absence of these implementations could lead to delays in the testing cycle. +Any updates to an EIP that is already at this stage **SHOULD** be accompanied by the appropriate updates to its implementation in [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md) and [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/blob/38621dc8f2cbc80a096e0906b28e4d4984752501/README.md) if deemed necessary by client developers. + ### Declined for Inclusion At any time during the network upgrade planning process, client developers **MAY** move EIPs from any other stage to the `Declined for Inclusion` stage if client teams are against including the EIP in the network upgrade. Once a decision is made by client teams to move an EIP to `Declined for Inclusion`, the Upgrade Meta EIP **SHOULD** be updated to reflect this. @@ -71,6 +73,8 @@ When client teams agree to implement a Core EIP in the **next** Upgrade Devnet, An EIP **MUST** have a Python implementation in [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md), submitted as an open PR or merged to the `devnets/upgradeName/version` branch of the repository, along with corresponding tests in [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/blob/38621dc8f2cbc80a096e0906b28e4d4984752501/README.md), also submitted as an open PR or merged to the `main` branch of the repository. Client developers **MAY** decide to allow an EIP to be moved to `Scheduled for Inclusion` without an [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md) implementation, but the tests are strictly mandatory. +Any updates to an EIP that is already at this stage **MUST** be accompanied by the appropriate updates to its implementation in [execution-specs](https://github.com/ethereum/execution-specs/blob/78fb726158c69d8fa164e28f195fabf6ab59b915/README.md) and [execution-spec-tests](https://github.com/ethereum/execution-spec-tests/blob/38621dc8f2cbc80a096e0906b28e4d4984752501/README.md) if deemed necessary by client developers. + `Scheduled for Inclusion` signals that implementation and testing work are underway. The EIP **SHOULD** be included in the network upgrade if no issues arise. The latest Upgrade Devnet must contain all `Scheduled for Inclusion` Core EIPs. An EIP **MAY** be moved from `Scheduled for Inclusion` to `Declined for Inclusion` if client teams are against including the EIP in the network upgrade. An EIP **MAY** also be moved from `Scheduled for Inclusion` to `Considered for Inclusion` if client teams are in favor of including the EIP in the network upgrade but cannot commit to including it in the **next** Upgrade Devnet.