From 65555260fc15b5b81c6d280702591011931cbc7d Mon Sep 17 00:00:00 2001 From: Adrian Sutton Date: Tue, 17 Mar 2026 09:55:13 +0000 Subject: [PATCH 1/2] fix: correct cd paths in kona action test recipes SOURCE is rust/kona/tests (3 levels deep), so reaching op-e2e/ at the repo root requires ../../../ not ../../. The broken paths caused cd to fail silently (no set -e), then gotestsum ran in the wrong directory finding no Go files. The `exit 0` in the parallel branch masked the failure, making CI report success despite no tests actually running. Co-Authored-By: Claude Opus 4.6 (1M context) --- rust/kona/tests/justfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/kona/tests/justfile b/rust/kona/tests/justfile index 6139e49d132c9..a07d8c27d8114 100644 --- a/rust/kona/tests/justfile +++ b/rust/kona/tests/justfile @@ -198,7 +198,7 @@ action-tests-single-run test_name='Test_ProgramAction' parallel="0" *args='': # https://github.com/gotestyourself/gotestsum/blob/b4b13345fee56744d80016a20b760d3599c13504/testjson/format.go#L442-L444 echo "Running action tests for the client program on the native target" - cd {{SOURCE}}/../../op-e2e/actions/proofs + cd {{SOURCE}}/../../../op-e2e/actions/proofs # Set parallel to the number of cores available if {{parallel}} is not greater than 0 if [ {{parallel}} -gt 0 ]; then @@ -251,7 +251,7 @@ action-tests-interop-run test_name='TestInteropFaultProofs' *args='': # https://github.com/gotestyourself/gotestsum/blob/b4b13345fee56744d80016a20b760d3599c13504/testjson/format.go#L442-L444 echo "Running action tests for the client program on the native target" - cd {{SOURCE}}/../../op-e2e/actions/interop && GITHUB_ACTIONS=false {{SOURCE}}/../../../ops/scripts/gotestsum-split.sh --format=short-verbose -- -count=1 -timeout 60m -run "{{test_name}}" {{args}} + cd {{SOURCE}}/../../../op-e2e/actions/interop && GITHUB_ACTIONS=false {{SOURCE}}/../../../ops/scripts/gotestsum-split.sh --format=short-verbose -- -count=1 -timeout 60m -run "{{test_name}}" {{args}} update-packages: #!/bin/bash From ff8d8bc84d780a4b37ff41c39ec211b687d310a6 Mon Sep 17 00:00:00 2001 From: Adrian Sutton Date: Tue, 17 Mar 2026 09:56:23 +0000 Subject: [PATCH 2/2] fix: add set -euo pipefail and remove exit 0 mask in kona action tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The action-tests-single-run and action-tests-interop-run recipes had no set -e, so a failed cd (or any other command) would silently continue. Combined with `exit 0` in the parallel branch, this masked failures entirely — CI reported success with zero tests running. - Add `set -euo pipefail` to both recipes so any failure aborts - Replace `exit 0` with `exit` so xargs/gotestsum's exit code propagates Co-Authored-By: Claude Opus 4.6 (1M context) --- rust/kona/tests/justfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rust/kona/tests/justfile b/rust/kona/tests/justfile index a07d8c27d8114..d46e36d5c5522 100644 --- a/rust/kona/tests/justfile +++ b/rust/kona/tests/justfile @@ -187,6 +187,7 @@ action-tests-build: # Run action tests for the single-chain client program on the native target action-tests-single-run test_name='Test_ProgramAction' parallel="0" *args='': #!/bin/bash + set -euo pipefail if [ ! -n "$KONA_HOST_PATH" ]; then export KONA_HOST_PATH="{{SOURCE}}/../target/release/kona-host" @@ -229,7 +230,7 @@ action-tests-single-run test_name='Test_ProgramAction' parallel="0" *args='': # so split once at the end rather than wrapping each call. {{SOURCE}}/../../../ops/scripts/split-test-logs.sh ./tmp/testlogs/log-$NODE_INDEX.json - exit 0 + exit fi {{SOURCE}}/../../../ops/scripts/gotestsum-split.sh --format=testname \ @@ -242,6 +243,7 @@ action-tests-interop test_name='TestInteropFaultProofs' *args='': action-tests-b action-tests-interop-run test_name='TestInteropFaultProofs' *args='': #!/bin/bash + set -euo pipefail echo "Building host program for the native target" just build-native --bin kona-host