Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SuperchainWETH): enable sending and relaying ETH via SuperchainWETH contract #12710

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

tremarkley
Copy link
Contributor

@tremarkley tremarkley commented Oct 28, 2024

Implements: ethereum-optimism/design-docs#146

Adds two new functions to the SuperchainWETH contract: sendETH and relayETH.

  • sendETH: Deposits ETH in the ETHLiquidity contract and sends a message to the destination chain, encoding the relay details.
  • relayETH: Withdraws the specified amount of ETH from ETHLiquidity on the destination chain and transfers it to the recipient.

This update streamlines L2-to-L2 ETH transfers, bypassing the need for separate wrapping and unwrapping steps. Notably, custom gas token chains are excluded from this simplification to maintain compatibility and reduce risk.

@tremarkley
Copy link
Contributor Author

tremarkley commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch from d6448db to ad3c9f2 Compare October 28, 2024 22:35
@tremarkley tremarkley changed the title feat(protoype): enable superchainWETH native transfers feat(protoype): enable SuperchainWETH native transfers Oct 28, 2024
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch 8 times, most recently from c3d9f27 to b5d9b23 Compare October 29, 2024 00:13
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch 3 times, most recently from 9600bd7 to 2668a39 Compare October 29, 2024 16:37
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch 2 times, most recently from 8fc8a01 to 3819c83 Compare November 18, 2024 23:23
@tremarkley tremarkley changed the title feat(protoype): enable SuperchainWETH native transfers feat(SuperchainWETH): enable sending and relaying ETH via SuperchainWETH contract Nov 18, 2024
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch 5 times, most recently from cacf39d to 54cbef5 Compare November 19, 2024 01:12
@tremarkley tremarkley marked this pull request as ready for review November 19, 2024 01:20
@tremarkley tremarkley requested a review from a team as a code owner November 19, 2024 01:20
@tremarkley tremarkley changed the title feat(SuperchainWETH): enable sending and relaying ETH via SuperchainWETH contract feat(SuperchainWETH): enable sending and relaying ETH via SuperchainWETH contract Nov 19, 2024
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch 5 times, most recently from 8d01b37 to 2b0fb0a Compare November 21, 2024 01:15
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch 4 times, most recently from 3f06e31 to 3da0118 Compare November 26, 2024 18:24
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch from 3da0118 to f8e96b2 Compare November 26, 2024 18:38
@tremarkley tremarkley force-pushed the harry/superchainweth_native_transfer branch from f8e96b2 to 341ff25 Compare November 26, 2024 18:44
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.71%. Comparing base (9200bff) to head (341ff25).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12710      +/-   ##
===========================================
- Coverage    44.30%   42.71%   -1.59%     
===========================================
  Files          798      742      -56     
  Lines        71668    67003    -4665     
===========================================
- Hits         31751    28620    -3131     
+ Misses       37335    35972    -1363     
+ Partials      2582     2411     -171     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

@tynes
Copy link
Contributor

tynes commented Nov 26, 2024

@tremarkley tremarkley added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 72eb311 Nov 26, 2024
46 checks passed
@tremarkley tremarkley deleted the harry/superchainweth_native_transfer branch November 26, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants