This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Merged
Conversation
clabby
reviewed
Apr 6, 2024
clabby
approved these changes
Apr 14, 2024
Contributor
There was a problem hiding this comment.
Looking very good; Nice work.
Approving to get this into trunk and continue iteration. Looks like L1BlockInfo parsing is blocking completion, where it's also blocking #98. Maybe we split the parsing of the L1 block info from calldata into another PR and put #98 on pause for the moment?
wrt needing more information in the payload builder, maybe we change info_by_hash in the ChainProvider to header_by_hash? The BlockInfo (for L1) is just a subset of the header's information, looks like we need the full header here. This contains the mix hash, parent beacon block root, etc., and we have a hint route for it as well: https://specs.optimism.io/experimental/fault-proof/index.html#l1-block-header-blockhash
clabby
force-pushed
the
refcell/attributes-builder
branch
4 times, most recently
from
ba5058c to
d65b9af
Compare
clabby
force-pushed
the
refcell/attributes-builder
branch
from
d65b9af to
bca50b7
Compare
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
* feat(derive): attributes building * feat(derive): ecotone tx building setup * fix(derive): attribute builder * fix(derive): use chain provider * fix(derive): deposit tx work * fix(derive): deposit tx work * fix(derive): migrate deposit utility methods to types * fix(derive): deposit unmarshalling test * fix(derive): ecotone transactions * fix(derive): ecotone transaction building * fix(derive): op-alloy-consensus bump * fix(derive): point to clabby's branch * fix(derive): remove lazy static * chore(derive): Review changes --------- Co-authored-by: clabby <ben@clab.by>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
* feat(derive): attributes building * feat(derive): ecotone tx building setup * fix(derive): attribute builder * fix(derive): use chain provider * fix(derive): deposit tx work * fix(derive): deposit tx work * fix(derive): migrate deposit utility methods to types * fix(derive): deposit unmarshalling test * fix(derive): ecotone transactions * fix(derive): ecotone transaction building * fix(derive): op-alloy-consensus bump * fix(derive): point to clabby's branch * fix(derive): remove lazy static * chore(derive): Review changes --------- Co-authored-by: clabby <ben@clab.by>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starts implementing a
StatefulAttributesBuilderas a default implementation of theAttributesBuildertrait.Metadata
Makes significant, tested progress on #54. There are a few more things to fix and implement to fully build payload attributes.