Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(derive): BatchQueue Implementation#67

Merged
refcell merged 11 commits intomainfrom
refcell/batch-queue
Apr 3, 2024
Merged

feat(derive): BatchQueue Implementation#67
refcell merged 11 commits intomainfrom
refcell/batch-queue

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Mar 29, 2024

Description

Implements the BatchQueue.

Metadata

Fixes #52

@refcell refcell requested review from clabby and tynes March 29, 2024 21:56
@refcell refcell self-assigned this Mar 29, 2024
@refcell refcell added K-feature Kind: feature A-proof Area: proof crates labels Mar 29, 2024
@refcell refcell force-pushed the refcell/batch-type branch from f777b0e to e857519 Compare March 30, 2024 21:29
@refcell refcell force-pushed the refcell/batch-queue branch from ce2e4a1 to d367951 Compare March 30, 2024 21:47
Base automatically changed from refcell/batch-type to main April 3, 2024 01:50
@refcell refcell marked this pull request as ready for review April 3, 2024 16:23
Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. The business logic in the BatchQueue seems to be correct when compared with the Go implementation.

Couple small nits, then should be good to get into trunk to keep iterating on 🚀

@refcell refcell requested a review from clabby April 3, 2024 18:10
@refcell refcell merged commit 2ca2031 into main Apr 3, 2024
@refcell refcell deleted the refcell/batch-queue branch April 3, 2024 18:44
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
This was referenced May 29, 2024
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
…-queue

feat(derive): BatchQueue Implementation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-proof Area: proof crates K-feature Kind: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(derive): Batch Queue stage

2 participants