Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(mpt): Fix extension node truncation#300

Merged
refcell merged 2 commits intomainfrom
cl/trie-refactor
Jun 22, 2024
Merged

fix(mpt): Fix extension node truncation#300
refcell merged 2 commits intomainfrom
cl/trie-refactor

Conversation

@clabby
Copy link
Copy Markdown
Contributor

@clabby clabby commented Jun 22, 2024

Overview

Fixes extension node truncation as well as branch node compaction in the mpt crate. Also removes the *_inner functions in favor of easier-to-read slice cursors.

## Overview

Fixes extension node truncation in the `mpt` crate and does some
cleanups.
Copy link
Copy Markdown
Contributor Author

clabby commented Jun 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 88.70968% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.6%. Comparing base (0f5d9ab) to head (a46f753).

Files Patch % Lines
crates/mpt/src/node.rs 89.7% 5 Missing ⚠️
crates/mpt/src/db/mod.rs 84.6% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby self-assigned this Jun 22, 2024
@clabby clabby added A-mpt K-fix Kind: fix labels Jun 22, 2024
Fixes a deletion when the final remaining node in a branch is a branch.
@clabby clabby force-pushed the cl/trie-refactor branch from d636bb9 to a46f753 Compare June 22, 2024 20:24
Copy link
Copy Markdown
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests 👍

@refcell refcell added this pull request to the merge queue Jun 22, 2024
Merged via the queue into main with commit 258f020 Jun 22, 2024
This was referenced Jun 22, 2024
refcell pushed a commit that referenced this pull request Jun 25, 2024
* fix(mpt): Fix extension node truncation

## Overview

Fixes extension node truncation in the `mpt` crate and does some
cleanups.

* fix(mpt): Deletion (branch within branch)

Fixes a deletion when the final remaining node in a branch is a branch.
@clabby clabby deleted the cl/trie-refactor branch July 2, 2024 03:38
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
* fix(mpt): Fix extension node truncation

## Overview

Fixes extension node truncation in the `mpt` crate and does some
cleanups.

* fix(mpt): Deletion (branch within branch)

Fixes a deletion when the final remaining node in a branch is a branch.
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
* fix(mpt): Fix extension node truncation

## Overview

Fixes extension node truncation in the `mpt` crate and does some
cleanups.

* fix(mpt): Deletion (branch within branch)

Fixes a deletion when the final remaining node in a branch is a branch.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-fix Kind: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants