Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(preimage): add serde feature flag to preimage crate for keys#271

Merged
clabby merged 4 commits intoop-rs:mainfrom
succinctlabs:zach/serde-preimage-flag
Jun 17, 2024
Merged

feat(preimage): add serde feature flag to preimage crate for keys#271
clabby merged 4 commits intoop-rs:mainfrom
succinctlabs:zach/serde-preimage-flag

Conversation

@zobront
Copy link
Contributor

@zobront zobront commented Jun 17, 2024

Description

We need to Serialize and Deserialize traits implemented on PreimageKeys to pass them into the zkVM. Adding a feature flag to the preimage crate to do that.

Tests

N/A

Additional context

N/A

Metadata

N/A

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.3%. Comparing base (5a2325c) to head (2673f74).
Report is 2 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added this pull request to the merge queue Jun 17, 2024
Merged via the queue into op-rs:main with commit bbd5fa0 Jun 17, 2024
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
@zobront zobront deleted the zach/serde-preimage-flag branch June 17, 2024 15:29
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
…-rs/kona#271)

* add serde flag to preimage crate for keys

* cargo.toml update

* dep:serde

* derive feature
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
…-rs/kona#271)

* add serde flag to preimage crate for keys

* cargo.toml update

* dep:serde

* derive feature
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants