This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix: output root version to 32 bytes#248
Merged
clabby merged 3 commits intoop-rs:mainfrom Jun 14, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@clabby Put reminder to add a test later, ready to merge. |
clabby
approved these changes
Jun 14, 2024
Closed
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
* output root version to 32 bytes * add test todo * cleanup
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
* output root version to 32 bytes * add test todo * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
compute_output_root()function set theOUTPUT_ROOT_VERSIONto just 1 byte, when it should be 32 bytes per the spec.This PR corrects the calculation by left padding the
OUTPUT_ROOT_VERSIONwith 31 bytes of 0s.Tests
None of the existing block tests align with known output roots on chain, so will require aggregating new test data. I can use
debugRPC calls to get the header and transactions, but not sure about setting up the testdata to act as the fetcher. Do you have a workflow for putting that together?Additional context
N/A
Metadata
N/A