Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(kona-derive): Updated interface#230

Merged
refcell merged 5 commits intomainfrom
refcell/pipeline-rework
Jun 11, 2024
Merged

feat(kona-derive): Updated interface#230
refcell merged 5 commits intomainfrom
refcell/pipeline-rework

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jun 10, 2024

Description

Updates the Pipeline interface to include a set_origin method and updates the reset method to perform the pipeline reset.

Copy link
Contributor Author

refcell commented Jun 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title feat(kona-derive): pipeline output validation feat(kona-derive): Updated interface Jun 10, 2024
@refcell refcell requested a review from clabby June 10, 2024 23:18
@refcell refcell added A-proof Area: proof crates K-fix Kind: fix labels Jun 10, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 10, 2024 23:47
@refcell refcell self-assigned this Jun 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@518c8d8). Learn more about missing BASE report.

Files Patch % Lines
crates/derive/src/pipeline/core.rs 0.00% 35 Missing ⚠️
crates/derive/src/pipeline/builder.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage        ?   74.38%           
=======================================
  Files           ?       98           
  Lines           ?    10035           
  Branches        ?        0           
=======================================
  Hits            ?     7465           
  Misses          ?     2570           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell requested a review from clabby June 11, 2024 14:47
Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice mr wick

@refcell refcell enabled auto-merge June 11, 2024 14:59
@refcell refcell added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 9c2fa66 Jun 11, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
@clabby clabby deleted the refcell/pipeline-rework branch July 2, 2024 03:38
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
* feat(kona-derive): pipeline output validation

* fix(kona-derive): pipeline interface and associated builder:

* fixes

* Update crates/derive/src/online/validation.rs

Co-authored-by: clabby <ben@clab.by>

---------

Co-authored-by: clabby <ben@clab.by>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
* feat(kona-derive): pipeline output validation

* fix(kona-derive): pipeline interface and associated builder:

* fixes

* Update crates/derive/src/online/validation.rs

Co-authored-by: clabby <ben@clab.by>

---------

Co-authored-by: clabby <ben@clab.by>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-proof Area: proof crates K-fix Kind: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants