Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(kona-derive): Use Upstream ReqwestProvider#229

Merged
clabby merged 1 commit intomainfrom
refcell/use-upstream-reqwest-provider
Jun 11, 2024
Merged

fix(kona-derive): Use Upstream ReqwestProvider#229
clabby merged 1 commit intomainfrom
refcell/use-upstream-reqwest-provider

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jun 10, 2024

Description

Now that alloy dependencies are updated to use revision cb95183, online kona-derive provider implementations can reuse the exported ReqwestProvider type instead of defining a custom ReqwestClient type.

In a later revision we won't need to specify the return type or wrap the method str in a Borrowed Cow. For now though, we comply with the compiler's demands.

Copy link
Contributor Author

refcell commented Jun 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title fix(kona-derive): reuse upstream reqwest provider fix(kona-derive): Upstream ReqwestProvider Use Jun 10, 2024
@refcell refcell changed the title fix(kona-derive): Upstream ReqwestProvider Use fix(kona-derive): Use Upstream ReqwestProvider Jun 10, 2024
@refcell refcell requested a review from clabby June 10, 2024 16:07
@refcell refcell added K-chore Kind: chore A-proof Area: proof crates labels Jun 10, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 10, 2024 17:15
@refcell refcell self-assigned this Jun 10, 2024
@refcell refcell force-pushed the refcell/use-upstream-reqwest-provider branch from 4e69831 to c69bfb3 Compare June 11, 2024 15:31
@refcell refcell force-pushed the refcell/use-upstream-reqwest-provider branch from e47bcad to 22777dc Compare June 11, 2024 15:38
@refcell refcell requested a review from clabby June 11, 2024 15:38
@clabby clabby added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 8139286 Jun 11, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
@clabby clabby deleted the refcell/use-upstream-reqwest-provider branch July 2, 2024 03:38
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-proof Area: proof crates K-chore Kind: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants