This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix(primitives): use decode_2718() to gracefully handle the tx type#182
Merged
clabby merged 2 commits intoop-rs:mainfrom May 29, 2024
Merged
fix(primitives): use decode_2718() to gracefully handle the tx type#182clabby merged 2 commits intoop-rs:mainfrom
clabby merged 2 commits intoop-rs:mainfrom
Conversation
clabby
force-pushed
the
fix/op-tx-envelope-decoding
branch
from
2f798ad to
8119ac2
Compare
Contributor
|
Rebased on #186 - Closing & re-opening to bump CI :) |
clabby
reviewed
May 27, 2024
clabby
approved these changes
May 29, 2024
This was referenced May 29, 2024
Closed
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…p-rs/kona#182) * fix(primitives): use decode_2718() to gracefully handle the tx type * nit: space
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…p-rs/kona#182) * fix(primitives): use decode_2718() to gracefully handle the tx type * nit: space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe
decode_2718()will gracefully remove the transaction type byte, so I imported it from alloy_eips.Tests
I ran all existing tests, including all the decoding unit tests in
stages.Metadata