Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to set global password with http basic auth #255

Merged
merged 2 commits into from
Dec 4, 2011

Conversation

alx
Copy link
Contributor

@alx alx commented Dec 1, 2011

Related to issue #241

@alx
Copy link
Contributor Author

alx commented Dec 1, 2011

duplicate #241

@alx alx closed this Dec 1, 2011
@alx alx reopened this Dec 1, 2011
@alx
Copy link
Contributor Author

alx commented Dec 1, 2011

sorry, I thought it was a duplicated issue, still learning github interface.

if (req.headers.authorization) {
setTimeout(function () {
res.send('Authentication required', 401);
}, 5000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a timeout of 5 seconds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, new to node.js and express, found the example on : http://node-js.ru/3-writing-express-middleware

would it need to be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea was to slow down a brute force attack. I reduced it to 1s now

@Pita Pita merged commit a520c1e into ether:master Dec 4, 2011
@Pita
Copy link
Contributor

Pita commented Dec 4, 2011

thats merged, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants