feat(nx-spawn): Improve dependency execution #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wound up rewriting most of nx-spawn to pull from Nx's task runner code. We're now properly running dependencies only once and waiting for build outputs to be present before continuing with other tasks that rely on it.
To make
build-watch
/serve
work properly with this, I've also had to prevent vite from removing the dist directory when it rebuilds - see the comments in the core vite config. I've also made it automatically watch when running in development mode for convinience.Bonus: I realized that the reason why the package-lock kept getting corrupted from under me was because the
npm i
in the distify build process was touching it, and incorrectly changing some metadata. I've updated it to use--save=false
to avoid this.Resolves #13
Resolves #23