Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages to not use baseUrl #144

Closed
luxaritas opened this issue Aug 26, 2022 · 0 comments · Fixed by #157 · May be fixed by #179
Closed

Update packages to not use baseUrl #144

luxaritas opened this issue Aug 26, 2022 · 0 comments · Fixed by #157 · May be fixed by #179
Assignees
@luxaritas
Labels
priority: p5/chore 🧹 A cleanup with no end-user impact scope: repo Applicable to general repository upkeep type: ergonomics Tooling, refactoring, etc
Milestone
nx-plugin-v2.0.0

Comments

@luxaritas
Copy link
Member

We've opted to move away from setting baseUrl in our tsconfig in our generators and instead using an @ alias as 1) it's easier to handle more consistently with Vite and 2) it doesn't use nonstandard behavior of resolving "bare" imports to to something not node-modules.

We should update our packages in this repository to comply with that pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luxaritas luxaritas

Labels
priority: p5/chore 🧹 A cleanup with no end-user impact scope: repo Applicable to general repository upkeep type: ergonomics Tooling, refactoring, etc
Projects
None yet
Milestone
nx-plugin-v2.0.0
1 participant
@luxaritas