Skip to content

Conversation

@serathius
Copy link
Member

Backporting #15431 to release-3.4

cc @ahrtr @ptabor
Phase 1 of #15402 (comment)

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius serathius merged commit 08a42e6 into etcd-io:release-3.4 Mar 14, 2023
github.com/sirupsen/logrus v1.6.0 // indirect
go.uber.org/atomic v1.3.2 // indirect
go.uber.org/multierr v1.1.0 // indirect
golang.org/x/sync v0.1.0 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not correct. Why it's a indirect instead of a direct dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I added started using errgroup directly.

@ahrtr ahrtr mentioned this pull request Apr 10, 2023
@serathius serathius deleted the watch-random-scheduler-3.4 branch June 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants