Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated grpc-ecosystem/go-grpc-middleware v1 and grpc-ecosystem/go-grpc-prometheus #17883

Open
marefr opened this issue Apr 25, 2024 · 0 comments
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature

Comments

@marefr
Copy link
Contributor

marefr commented Apr 25, 2024

What would you like to be added?

Upgrade grpc-ecosystem/go-grpc-middleware to v2 and migrate grpc-ecosystem/go-grpc-prometheus to grpc-ecosystem/go-grpc-middleware/providers/prometheus.

Why is this needed?

Trying to get rid of deprecated go-grpc-middleware in https://github.com/grafana/grafana and this is the first stop on the path:

go mod why github.com/grpc-ecosystem/go-grpc-middleware
# github.com/grpc-ecosystem/go-grpc-middleware
github.com/grafana/grafana/pkg/apiserver/storage/file
k8s.io/apiserver/pkg/storage/storagebackend
k8s.io/apiserver/pkg/storage/etcd3
k8s.io/apiserver/pkg/storage/etcd3.test
go.etcd.io/etcd/server/v3/embed
go.etcd.io/etcd/server/v3/etcdserver/api/v3rpc
github.com/grpc-ecosystem/go-grpc-middleware
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature
2 participants