You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
uses the defaultUnaryMaxRetries to set the max retries, which is then checked if it is 0 and if it is we skip retries. But from my understanding, this can never be set or configured by users so it will always retry 100 times.
Retrying 100 times can result in very noisy logs (if the log level is warning for example), but also unnecessary retries if this is not something the user wants. I am proposing to make max retries configurable. In our (OpenShift) use case of the operator, we reconcile often enough that we do not require to retry 100 times.
Sorry if I missed something while going through the code!
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
etcd/client/v3/client.go
Line 241 in 4cbb949
defaultUnaryMaxRetries
to set the max retries, which is then checked if it is 0 and if it is we skip retries. But from my understanding, this can never be set or configured by users so it will always retry 100 times.Retrying 100 times can result in very noisy logs (if the log level is warning for example), but also unnecessary retries if this is not something the user wants. I am proposing to make max retries configurable. In our (OpenShift) use case of the operator, we reconcile often enough that we do not require to retry 100 times.
Sorry if I missed something while going through the code!
The text was updated successfully, but these errors were encountered: