Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub workflows for PRs with the ok-to-test label #43

Open
ivanvc opened this issue Jan 17, 2025 · 9 comments
Open

Enable GitHub workflows for PRs with the ok-to-test label #43

ivanvc opened this issue Jan 17, 2025 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ivanvc
Copy link
Member

ivanvc commented Jan 17, 2025

Allow running GitHub workflows for pull requests with the ok-to-test label using the prow bot command /ok-to-test. This is already done in most of etcd repositories (refer to the issue etcd-io/etcd#16956 and its PR etcd-io/etcd#16965, or etcd-io/bbolt#631 and etcd-io/bbolt#638).

Refer to etcd's .github/workflows/gh-workflow-approve.yaml and note that in this repository it should only run on the main branch.

This decreases the toil on maintainers as members can trigger tests by commenting /ok-to-test in pull requests.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 17, 2025

@jmhbnz / @ahrtr, can you help me set this up with "help wanted" and "good first issue" labels? I don't have permission in this repository.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 17, 2025

Hold on, do we even need this? How is it working if we don't have the workflow in this repository 🤔 . I see that it worked in this pull request: #40 (comment)

Do we even need it in other repositories if it works without the workflow?

EDIT: Never mind, we still need it because it only triggers prow jobs, not GitHub workflows.

SECOND EDIT: On second thought, if we're migrating everything to prow jobs, we may not need this workflow unless we want to keep it as a backup (in case someone adds a GitHub workflow rather than a prow job)

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

I don't have permission in this repository.

Please send a PR to fix this, thx.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 17, 2025

Please send a PR to fix this, thx.

I wanted to open this to new contributors, but I don't have permission to set the labels.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 17, 2025

/label help wanted
/label good first issue

@ivanvc
Copy link
Member Author

ivanvc commented Jan 17, 2025

/help

@ahrtr ahrtr added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 17, 2025
@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

I wanted to open this to new contributors, but I don't have permission to set the labels.

I mean to try to grant you the permission in a PR.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 17, 2025

I mean to try to grant you the permission in a PR.

Ah, got you. I think I know what it is. I'll take a look at it later today. Thanks!

@Dhairya-Dudhatra
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants