-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub workflows for PRs with the ok-to-test label #43
Comments
EDIT: Never mind, we still need it because it only triggers prow jobs, not GitHub workflows. SECOND EDIT: On second thought, if we're migrating everything to prow jobs, we may not need this workflow unless we want to keep it as a backup (in case someone adds a GitHub workflow rather than a prow job) |
Please send a PR to fix this, thx. |
I wanted to open this to new contributors, but I don't have permission to set the labels. |
/label help wanted |
/help |
I mean to try to grant you the permission in a PR. |
Ah, got you. I think I know what it is. I'll take a look at it later today. Thanks! |
/assign |
Allow running GitHub workflows for pull requests with the ok-to-test label using the prow bot command /ok-to-test. This is already done in most of etcd repositories (refer to the issue etcd-io/etcd#16956 and its PR etcd-io/etcd#16965, or etcd-io/bbolt#631 and etcd-io/bbolt#638).
Refer to etcd's .github/workflows/gh-workflow-approve.yaml and note that in this repository it should only run on the main branch.
This decreases the toil on maintainers as members can trigger tests by commenting
/ok-to-test
in pull requests.The text was updated successfully, but these errors were encountered: