diff --git a/.github/workflows/failpoint_test.yaml b/.github/workflows/failpoint_test.yaml index ce626ca45..17546a8e7 100644 --- a/.github/workflows/failpoint_test.yaml +++ b/.github/workflows/failpoint_test.yaml @@ -15,6 +15,10 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: go-version: ${{ steps.goversion.outputs.goversion }} + - name: Run golangci-lint + uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 + with: + version: v2.1.6 - run: | make gofail-enable make test-failpoint diff --git a/.github/workflows/robustness_template.yaml b/.github/workflows/robustness_template.yaml index befe7dfe2..f742476ae 100644 --- a/.github/workflows/robustness_template.yaml +++ b/.github/workflows/robustness_template.yaml @@ -29,6 +29,10 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: go-version: ${{ steps.goversion.outputs.goversion }} + - name: Run golangci-lint + uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 + with: + version: v2.1.6 - name: test-robustness run: | set -euo pipefail diff --git a/.github/workflows/tests-template.yml b/.github/workflows/tests-template.yml index ad92c8c70..c39e701ea 100644 --- a/.github/workflows/tests-template.yml +++ b/.github/workflows/tests-template.yml @@ -49,7 +49,7 @@ jobs: exit 1 ;; esac - - name: golangci-lint + - name: Run golangci-lint uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 with: version: v2.1.6 diff --git a/.github/workflows/tests_amd64.yaml b/.github/workflows/tests_amd64.yaml index 7372dd7b2..ae80142d5 100644 --- a/.github/workflows/tests_amd64.yaml +++ b/.github/workflows/tests_amd64.yaml @@ -23,4 +23,8 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: go-version: ${{ steps.goversion.outputs.goversion }} + - name: Run golangci-lint + uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 + with: + version: v2.1.6 - run: make coverage diff --git a/.github/workflows/tests_arm64.yaml b/.github/workflows/tests_arm64.yaml index ceeb4fd96..195786817 100644 --- a/.github/workflows/tests_arm64.yaml +++ b/.github/workflows/tests_arm64.yaml @@ -25,4 +25,8 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: go-version: ${{ steps.goversion.outputs.goversion }} + - name: Run golangci-lint + uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 + with: + version: v2.1.6 - run: make coverage diff --git a/.github/workflows/tests_windows.yml b/.github/workflows/tests_windows.yml index 54546e146..79f9163c5 100644 --- a/.github/workflows/tests_windows.yml +++ b/.github/workflows/tests_windows.yml @@ -39,7 +39,7 @@ jobs: ;; esac shell: bash - - name: golangci-lint + - name: Run golangci-lint uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 with: version: v2.1.6 @@ -54,4 +54,8 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: go-version: ${{ steps.goversion.outputs.goversion }} + - name: Run golangci-lint + uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 + with: + version: v2.1.6 - run: make coverage diff --git a/.golangci.yaml b/.golangci.yaml index 68fc13184..bef3f6de7 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -1,8 +1,14 @@ formatters: enable: + - gci - gofmt - goimports settings: # please keep this alphabetized + gci: + sections: + - standard + - default + - prefix(go.etcd.io) goimports: local-prefixes: - go.etcd.io # Put imports beginning with prefix after 3rd-party packages. diff --git a/bolt_aix.go b/bolt_aix.go index af37741da..596e54060 100644 --- a/bolt_aix.go +++ b/bolt_aix.go @@ -8,8 +8,9 @@ import ( "time" "unsafe" - "go.etcd.io/bbolt/internal/common" "golang.org/x/sys/unix" + + "go.etcd.io/bbolt/internal/common" ) // flock acquires an advisory lock on a file descriptor. diff --git a/bolt_android.go b/bolt_android.go index 1d095ae9b..ac64fcf5b 100644 --- a/bolt_android.go +++ b/bolt_android.go @@ -6,8 +6,9 @@ import ( "time" "unsafe" - "go.etcd.io/bbolt/internal/common" "golang.org/x/sys/unix" + + "go.etcd.io/bbolt/internal/common" ) // flock acquires an advisory lock on a file descriptor. diff --git a/bolt_solaris.go b/bolt_solaris.go index 9fe1e7e92..56b2ccab4 100644 --- a/bolt_solaris.go +++ b/bolt_solaris.go @@ -6,8 +6,9 @@ import ( "time" "unsafe" - "go.etcd.io/bbolt/internal/common" "golang.org/x/sys/unix" + + "go.etcd.io/bbolt/internal/common" ) // flock acquires an advisory lock on a file descriptor. diff --git a/cmd/bbolt/main_test.go b/cmd/bbolt/main_test.go index 727b38f55..173d6595f 100644 --- a/cmd/bbolt/main_test.go +++ b/cmd/bbolt/main_test.go @@ -14,14 +14,13 @@ import ( "sync" "testing" - "go.etcd.io/bbolt/internal/btesting" - "go.etcd.io/bbolt/internal/guts_cli" - "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" bolt "go.etcd.io/bbolt" main "go.etcd.io/bbolt/cmd/bbolt" + "go.etcd.io/bbolt/internal/btesting" + "go.etcd.io/bbolt/internal/guts_cli" ) // Ensure the "info" command can print information about a database. diff --git a/movebucket_test.go b/movebucket_test.go index a04e24c9c..9c09825e6 100644 --- a/movebucket_test.go +++ b/movebucket_test.go @@ -7,11 +7,11 @@ import ( "path/filepath" "testing" + "github.com/stretchr/testify/require" + "go.etcd.io/bbolt" "go.etcd.io/bbolt/errors" "go.etcd.io/bbolt/internal/btesting" - - "github.com/stretchr/testify/require" ) func TestTx_MoveBucket(t *testing.T) { diff --git a/tests/dmflakey/dmflakey_test.go b/tests/dmflakey/dmflakey_test.go index 99e2de062..9e4229534 100644 --- a/tests/dmflakey/dmflakey_test.go +++ b/tests/dmflakey/dmflakey_test.go @@ -12,11 +12,11 @@ import ( "testing" "time" - testutils "go.etcd.io/bbolt/tests/utils" - "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "golang.org/x/sys/unix" + + testutils "go.etcd.io/bbolt/tests/utils" ) func TestMain(m *testing.M) { diff --git a/tests/robustness/powerfailure_test.go b/tests/robustness/powerfailure_test.go index 4d960b325..54c611cbf 100644 --- a/tests/robustness/powerfailure_test.go +++ b/tests/robustness/powerfailure_test.go @@ -19,11 +19,11 @@ import ( "testing" "time" - "go.etcd.io/bbolt/tests/dmflakey" - "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "golang.org/x/sys/unix" + + "go.etcd.io/bbolt/tests/dmflakey" ) var panicFailpoints = []string{