Skip to content

internal/freelist: make pcache a map of struct{} #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

internal/freelist: make pcache a map of struct{} #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/freelist/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,18 +220,18 @@ func (t *shared) Reload(p *common.Page) {

func (t *shared) NoSyncReload(pgIds common.Pgids) {
// Build a cache of only pending pages.
pcache := make(map[common.Pgid]bool)
pcache := make(map[common.Pgid]struct{})
for _, txp := range t.pending {
for _, pendingID := range txp.ids {
pcache[pendingID] = true
pcache[pendingID] = struct{}{}
}
}

// Check each page in the freelist and build a new available freelist
// with any pages not in the pending lists.
a := []common.Pgid{}
for _, id := range pgIds {
if !pcache[id] {
if _, ok := pcache[id]; !ok {
a = append(a, id)
}
}
Expand Down
Loading