Top level variables don't have references assigned

[jbrumwell]

Give the following code and using http://mazurov.github.io/escope-demo/;

const a = 'b';
a = 'c';
testing(a);

You can see the variable a has an empty references property here, The references are available under scope.references just not attached to the variable.

[mysticatea]

I got same bug.

var a = 0;
function foo() {
  a = 1;
}

In this case, references of a becomes an empty array.
I expect it to be 2 references; a = 0 and a = 1.

Each scope have a reference that its Reference.resolved property is null.

[michaelficarra]

For top-level vars, this behaviour makes sense: you can't tell if that will be a reference or not because the scope is dynamic:

var a = 0;
delete global.a;
a;

Technically, we can be certain that the initialisation is a reference, so we could have either one or zero references. But I like the consistency of never tracking references for variables in dynamic scopes.

For let/const variables, though, the references should be tracked. That is a bug.

[mysticatea]

Thanks for explain!
I got it.

[mysticatea]

I'm trying to fix this issue: mysticatea@c644d82

Now, it became passing very simple test cases.
But I'm worried about whether the direction of modifications is correct.

I modified Scope.prototype.__close method.
If the scope is the top-level, checks whether each reference is let/const/class's.

I have not found the meaning that Variable's defs is an array yet.
I'm going to add more test cases.

I'm sorry, my poor English...
Thanks.

[Constellation]

Great! Let's send pull request!