Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quotes around -ldflags. #46

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Conversation

avian2
Copy link
Contributor

@avian2 avian2 commented Sep 5, 2017

This prevents "-X flag requires argument of the form importpath.name=value"
error from go when doing "make build" (at least on Debian, Docker 17.06.1,
GNU Make 4.0)

This prevents "-X flag requires argument of the form importpath.name=value"
error from go when doing "make build" (at least on Debian, Docker 17.06.1,
GNU Make 4.0)
Copy link
Owner

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@estesp estesp merged commit ff34a20 into estesp:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants