Print lenght of manifest for notary signing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows then to manually sign the manifest with notary and enable content trust for multiarch images. Signed-off-by: Rolf Neugebauer <[email protected]>
Apparently a '.' at the end of a error string is verboten. Signed-off-by: Rolf Neugebauer <[email protected]>
Signed-off-by: Rolf Neugebauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To sign a manifest,
notaryneeds to know the length of the manifest. The first commit passes this information from fromPushManifestback topushwhere it is printed out. This has been tested and is now already the default with linuxkit, where we now push signed manifests.The other two commits are cosmetic
golintandineffassignfixes to allow us to buildmanifest-toolwith the LinuxKit tooling. I can split this into a separate PR if desired