Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add support for EXTRA_PARTITION_SUBTYPES in Partition Table Editor (VSC-1014) #851

Open
IH303 opened this issue Nov 28, 2022 · 2 comments
Labels
Feature / Enhancement Request Request for Feature/ Enhancement ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot

Comments

@IH303
Copy link

IH303 commented Nov 28, 2022

I have some custom partition subtypes. I defined them as described here using the EXTRA_PARTITION_SUBTYPES property.
E.g.:

idf_build_set_property(EXTRA_PARTITION_SUBTYPES "data, rsa, 0x9a" APPEND)

The ESP-IDF Partition Table Editor does not recognize those custom subtypes (or their names). They are not shown in the drop-down menu. Typing them manually is also not accepted.

It would be great, if I could chose my custom defined subtypes from the drop-down menu instead of typing hex strings.
Currently I also cannot add a custom subtype using hex strings for the type data because it says:

When type is "data", the subtype field can be specified as "ota" (0x00), "phy" (0x01), "nvs" (0x02), "nvs_keys" (0x04), "fat" (0x81), > "spiffs" (0x82) or a range of other component-specific subtypes (0x05, 0x06, 0x80, 0x81, 0x82)"

With the support for EXTRA_PARTITION_SUBTYPES the user could add his own component-specific subtypes for the type data

In short:
Add the possibility to chose custom subtypes defined with the EXTRA_PARTITION_SUBTYPES property from the drop-down menu in the ESP-IDF Partition Table Editor

I hope it is possible for you to implement this feature. Thank you.

@IH303 IH303 added the Feature / Enhancement Request Request for Feature/ Enhancement label Nov 28, 2022
@github-actions github-actions bot changed the title [Feature Request]: Add support for EXTRA_PARTITION_SUBTYPES in Partition Table Editor [Feature Request]: Add support for EXTRA_PARTITION_SUBTYPES in Partition Table Editor (VSC-1014) Nov 28, 2022
@github-actions
Copy link

This issue has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Dec 14, 2022
@brianignacio5 brianignacio5 added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Jan 5, 2023
@brianignacio5 brianignacio5 reopened this Jan 5, 2023
@brianignacio5
Copy link
Collaborator

The problem with this is that EXTRA_PARTITION_SUBTYPES is defined in CMakeLists.txt so using a custom partition.csv can't know before the build that these types exists.

Need to discuss with ESP-IDF colleagues about this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Enhancement Request Request for Feature/ Enhancement ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

No branches or pull requests

3 participants
@brianignacio5 @IH303 and others