Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VSC-1551] rm powershell no profile arg idf terminal #1388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[VSC-1551] rm powershell no profile arg idf terminal #1388

wants to merge 1 commit into from

Conversation

brianignacio5
Copy link
Collaborator

Description

Remove -NoProfile argument in ESP-IDF: Open ESP-IDF Terminal to avoid user restriction of profiles. Was added due to script need to run in Powershell to ByPass execution policy in order to add command shortcuts.

Fixes #1387

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Open ESP-IDF Terminal`". The Terminal should allow user to apply a Powershell profile now.
  2. Execute action.
  3. Observe results.

How has this been tested?

Manual testing on Windows.

Test Configuration:

  • ESP-IDF Version: 5.3.2
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Dec 27, 2024
@brianignacio5 brianignacio5 added this to the v1.9.1 milestone Dec 27, 2024
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

radurentea
radurentea approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fabricio-ESP Fabricio-ESP changed the title rm powershell no profile arg idf terminal [VSC-1551] rm powershell no profile arg idf terminal Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radurentea radurentea radurentea approved these changes

@Fabricio-ESP Fabricio-ESP Awaiting requested review from Fabricio-ESP

Assignees

@brianignacio5 brianignacio5

Labels
None yet
Projects
None yet
Milestone
v1.9.1
2 participants
@brianignacio5 @radurentea