Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update installation instructions for 1.54.0 #20

Merged
merged 10 commits into from
Aug 12, 2021
Merged

Conversation

georgik
Copy link
Collaborator

@georgik georgik commented Aug 4, 2021

Closes #19

Note: Not all artifacts are available for the download now.

@georgik georgik self-assigned this Aug 4, 2021
@georgik georgik changed the title WIP: docs: update installation instructions for 1.54.0 docs: update installation instructions for 1.54.0 Aug 6, 2021
@georgik georgik requested review from igrr and rgcottrell August 6, 2021 12:40
@nevi-me
Copy link

nevi-me commented Aug 9, 2021

I've followed the instructions on this PR (for M1), and managed to build successfully without getting the #3 issue.

When flashing to the device, I however get the error:

Serial port /dev/cu.usbserial-1130
Connecting....

A fatal error occurred: This chip is ESP32-C3 not ESP32. Wrong --chip argument?
CMake Error at run_serial_tool.cmake:56 (message):
  /Users/nevilledipale/.espressif/python_env/idf4.4_py3.9_env/bin/python
  /Users/nevilledipale/esp/esp-idf/components/esptool_py/esptool/esptool.py
  --chip esp32 failed

I had set up esp-idf with esp32-c3, so I don't know what I'm doing wrong.

Given that esp32-c3 doesn't use Xtensa (at least that's my understanding), does it mean that I'm building incorrectly for esp32 through these instructions?

@igrr
Copy link
Member

igrr commented Aug 9, 2021

The instructions indeed produce a build for esp32, by default. If you need to build for esp32-c3, please run idf.py set-target esp32c3 before running idf.py build.

@georgik
Copy link
Collaborator Author

georgik commented Aug 9, 2021

@nevi-me Thank you for pointing out the problem. Selection of the architecture was not obvious from the documentation. I've updated all documents, so that they contain selection of the architecture and also the reference to C3 installation instructions.

@georgik
Copy link
Collaborator Author

georgik commented Aug 9, 2021

@MabezDev Please review updated instructions.

@nevi-me
Copy link

nevi-me commented Aug 9, 2021

@nevi-me Thank you for pointing out the problem. Selection of the architecture was not obvious from the documentation. I've updated all documents, so that they contain selection of the architecture and also the reference to C3 installation instructions.

Thanks @georgik. Am I correct in saying that for esp32-c3, I then don't need to follow this process?

If so, when I follow the C3 instructions in the main branch, I get the below just like with #3

error[E0432]: unresolved import `core::sync::atomic::AtomicUsize`
 --> /Users/{me}/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/stdarch/crates/std_detect/src/detect/cache.rs:8:5
  |
8 | use core::sync::atomic::AtomicUsize;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AtomicUsize` in `sync::atomic`

For more information about this error, try `rustc --explain E0432`.

@georgik
Copy link
Collaborator Author

georgik commented Aug 9, 2021

@nevi-me That's correct. C3 has limitation on Atomics. Please follow the discussion in #3 There is active work on resolving this issue.

@georgik georgik merged commit d6f26b6 into main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update installation instructions to esp-rs/rust 1.54
4 participants