Skip to content

Conversation

Vorrad
Copy link
Contributor

@Vorrad Vorrad commented Sep 16, 2025

Description

Update the dependency from driver to latest new driver components, to avoid compile mistakes in new IDF versions.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Sep 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Vorrad, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4d3dd25

@github-actions github-actions bot changed the title feat(lightbulb_driver): Update driver dependency feat(lightbulb_driver): Update driver dependency (AEGHB-1224) Sep 16, 2025
@@ -1,4 +1,4 @@
version: "1.10.1"
version: "1.10.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should increase the minor version, since the dependency change could lead to a build error if the user previously relies on the whole "driver" component implicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change made

@Vorrad Vorrad force-pushed the feat/update_driver_dependency branch from 988bb92 to 4d3dd25 Compare September 17, 2025 02:16
@espzav
Copy link
Contributor

espzav commented Oct 2, 2025

Hi, please, is there a plan make similar changes for button component? Thank you
Issue: https://github.com/espressif/esp-bsp/actions/runs/18189036919/job/51779706989?pr=655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants