Apply suggestions from code review

Co-authored-by: Lucas Saavedra Vaz <[email protected]>

Author: me-no-dev

libraries/Ethernet/examples/ETH_LAN8720/ETH_LAN8720.ino

@@ -18,7 +18,7 @@
 
 static bool eth_connected = false;
 
-// WARNING: WiFiEvent is called from a separate FreeRTOS task (thread)!
+// WARNING: onEvent is called from a separate FreeRTOS task (thread)!
 void onEvent(arduino_event_id_t event)
 {
   switch (event) {

libraries/Ethernet/examples/ETH_TLK110/ETH_TLK110.ino

@@ -16,7 +16,7 @@
 
 static bool eth_connected = false;
 
-// WARNING: WiFiEvent is called from a separate FreeRTOS task (thread)!
+// WARNING: onEvent is called from a separate FreeRTOS task (thread)!
 void onEvent(arduino_event_id_t event)
 {
   switch (event) {

libraries/Ethernet/src/ETH.h

@@ -63,7 +63,6 @@
 // This will be uncommented once custom SPI support is available in ESP-IDF
 #define ETH_SPI_SUPPORTS_CUSTOM 1
 
-// #include "WiFi.h"
 #include "Network.h"
 
 #if ETH_SPI_SUPPORTS_CUSTOM

libraries/Network/src/NetworkClient.h

@@ -17,8 +17,7 @@
   Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */
 
-#ifndef _WIFICLIENT_H_
-#define _WIFICLIENT_H_
+#pragma once
 
 
 #include "Arduino.h"
@@ -112,4 +111,3 @@ class NetworkClient : public ESPLwIPClient
     using Print::write;
 };
 
-#endif /* _WIFICLIENT_H_ */

libraries/Network/src/NetworkInterface.cpp

@@ -222,10 +222,10 @@ int NetworkInterface::waitStatusBits(int bits, uint32_t timeout_ms) const {
         return 0;
     }
     bits = xEventGroupWaitBits(
-        _interface_event_group,    // The event group being tested.
-        bits,  // The bits within the event group to wait for.
-        pdFALSE,         // bits should be cleared before returning.
-        pdTRUE,        // Don't wait for all bits, any bit will do.
+        _interface_event_group, // The event group being tested.
+        bits, // The bits within the event group to wait for.
+        pdFALSE, // bits should be cleared before returning.
+        pdTRUE, // Don't wait for all bits, any bit will do.
         timeout_ms / portTICK_PERIOD_MS ) & bits; // Wait a maximum of timeout_ms for any bit to be set.
     return bits;
 }
@@ -714,6 +714,5 @@ size_t NetworkInterface::printTo(Print & out) const {
         bytes += out.println();
     }
 
-    // bytes += out.println();
     return bytes;
 }

libraries/Network/src/NetworkServer.h

@@ -16,8 +16,7 @@
   License along with this library; if not, write to the Free Software
   Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */
-#ifndef _WIFISERVER_H_
-#define _WIFISERVER_H_
+#pragma once
 
 #include "Arduino.h"
 #include "Server.h"
@@ -59,4 +58,3 @@ class NetworkServer {
     int setTimeout(uint32_t seconds);
 };
 
-#endif /* _WIFISERVER_H_ */

libraries/Network/src/NetworkUdp.h

@@ -32,8 +32,8 @@
  * [email protected] 12/30/2008
  */
 
-#ifndef _WIFIUDP_H_
-#define _WIFIUDP_H_
+#ifndef _NETWORKUDP_H_
+#define _NETWORKUDP_H_
 
 #include <Arduino.h>
 #include <Udp.h>
@@ -74,4 +74,4 @@ class NetworkUDP : public UDP {
   uint16_t remotePort();
 };
 
-#endif /* _WIFIUDP_H_ */
+#endif /* _NETWORKUDP_H_ */

libraries/WiFi/src/AP.cpp

@@ -337,7 +337,4 @@ size_t APClass::printDriverInfo(Print & out) const{
     return bytes;
 }
 
-
-
-
 #endif /* SOC_WIFI_SUPPORTED */

libraries/WiFi/src/STA.cpp

@@ -7,7 +7,6 @@
 #include "WiFiGeneric.h"
 #include "WiFiSTA.h"
 #if SOC_WIFI_SUPPORTED
-
 #include <stdint.h>
 #include <stdbool.h>
 #include <stdio.h>

libraries/WiFi/src/WiFiGeneric.cpp

@@ -368,7 +368,7 @@ bool WiFiGenericClass::setHostname(const char * hostname)
  */
 void WiFiGenericClass::_eventCallback(arduino_event_t *event)
 {
-    if(!event) return;                                                       //Null would crash this function
+    if(!event) return; //Null would crash this function
 
     // log_d("Arduino Event: %d - %s", event->event_id, WiFi.eventName(event->event_id));
     if(event->event_id == ARDUINO_EVENT_WIFI_SCAN_DONE) {