Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Custom HTTP headers are lost on redirect in HTTPClient #8942

Open
ZakKemble opened this issue Jun 11, 2023 · 1 comment
Open

Bug: Custom HTTP headers are lost on redirect in HTTPClient #8942

ZakKemble opened this issue Jun 11, 2023 · 1 comment

Comments

@ZakKemble
Copy link

Custom HTTP headers (using HTTPClient::addHeader()) are lost if a redirect is encountered during the request. This fix (espressif/arduino-esp32#5973) needs to be applied here.

This bug is very troublesome when your API key is sent in the headers D:
@earlephilhower
Copy link
Collaborator

@ZakKemble you have a bug, a failing test case, and some code changes that fix it. Would you like to make a PR, since you have the best setup to test that it actually works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@earlephilhower @ZakKemble