Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--without=rust-docs breaks installs with Rust 1.66.0.0 #92

Closed
zRedShift opened this issue Dec 13, 2022 · 0 comments · Fixed by #93
Closed

--without=rust-docs breaks installs with Rust 1.66.0.0 #92

zRedShift opened this issue Dec 13, 2022 · 0 comments · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@zRedShift
Copy link

Bug description

Upstream rust added the rust-docs-json-preview component, so this breaks the --without command since it performs rudimentary string replacement and it turns rustc, rust-std-x86_64-unknown-linux-gnu, rust-docs, rust-docs-json-preview, cargo into rustc, rust-std-x86_64-unknown-linux-gnu, -json-preview, cargo, with -json-preview of course being non-existent.
https://github.com/esp-rs/espup/blob/main/src/toolchain/rust.rs#L106
https://github.com/esp-rs/espup/blob/main/src/toolchain/rust.rs#L121

  • Would you like to work on a fix? [y/n]

To Reproduce

Steps to reproduce the behavior:

  1. espup install -v 1.66.0.0
  2. Output:
install: creating uninstall script at ~/.rustup/toolchains/esp/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'rust-std-x86_64-unknown-linux-gnu'
install: installing component '-json-preview'
install: error: manifest for -json-preview does not exist at ~/.espressif/dist/rust/rust-nightly-x86_64-unknown-linux-gnu/-json-preview/manifest.in. see logs at '~/.rustup/toolchains/esp/lib/rustlib/install.log'

Expected behavior

Successful installation

Screenshots

Environment

Additional context

@zRedShift zRedShift added the bug Something isn't working label Dec 13, 2022
@SergioGasquez SergioGasquez linked a pull request Dec 14, 2022 that will close this issue
@SergioGasquez SergioGasquez self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants