Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Install MSVC dependency for x86_64-pc-windows-msvc #9

Closed
georgik opened this issue Oct 7, 2022 · 1 comment · Fixed by #27
Closed

Windows: Install MSVC dependency for x86_64-pc-windows-msvc #9

georgik opened this issue Oct 7, 2022 · 1 comment · Fixed by #27
Assignees
Labels
enhancement New feature or request

Comments

@georgik
Copy link
Contributor

georgik commented Oct 7, 2022

Install MSVC dependency for x86_64-pc-windows-msvc.

Without this dependency, the user will get an error during builds like:

error: linker `link.exe` not found
  |
  = note: program not found

Note: the msvc targets depend on the msvc linker, but `link.exe` was not found

Note: please ensure that VS 2013, VS 2015, VS 2017, VS 2019, or VS 2022 was installed with the Visual C++ option

How to simulate

Run the following command in Windows Sandbox:

 .\espup.exe install

Solution

Implemented here: https://github.com/espressif/idf-env/blob/main/src/rust.rs#L335

The following command installs required dependencies:

vs_BuildTools.exe --passive --wait --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --add Microsoft.VisualStudio.Component.Windows10SDK.20348

This command should be deployed before any cargo install takes place.

@georgik georgik added the enhancement New feature or request label Oct 7, 2022
@SergioGasquez SergioGasquez self-assigned this Oct 7, 2022
@SergioGasquez SergioGasquez linked a pull request Oct 18, 2022 that will close this issue
@SergioGasquez SergioGasquez reopened this Nov 4, 2022
@SergioGasquez
Copy link
Member

As discussed in #154, espup won't take care of installing this dependency.

@SergioGasquez SergioGasquez closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants