Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the way we check the installed Xtensa Rust version #199

Closed
SergioGasquez opened this issue Mar 8, 2023 · 0 comments · Fixed by #201
Closed

Update the way we check the installed Xtensa Rust version #199

SergioGasquez opened this issue Mar 8, 2023 · 0 comments · Fixed by #201
Assignees
@SergioGasquez
Labels
enhancement New feature or request

Comments

@SergioGasquez
Copy link
Member

Motivations

At the moment, we use cargo --version to check the version, hence if we release a 1.67.0.1 and the user runs espup update, cargo --version will also output 1.67.0. I added a warn message to let the user know this.

Solution

Starting from 1.68.0.0, we added a release description in rustc that contains the full extended semver. We should use this to check the installed version, so we know for sure if we have the same version installed or not.

See esp-rs/rust-build#194
@SergioGasquez SergioGasquez added the enhancement New feature or request label Mar 8, 2023
@SergioGasquez SergioGasquez self-assigned this Mar 8, 2023
@SergioGasquez SergioGasquez linked a pull request Mar 10, 2023 that will close this issue
Use rustc release description to check the installed version #201
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergioGasquez SergioGasquez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use rustc release description to check the installed version SergioGasquez/espup
1 participant
@SergioGasquez