Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CI to build and release both with and without the raspberry feature #250

Closed
jessebraham opened this issue Oct 3, 2022 · 1 comment · Fixed by #255
Closed

Modify CI to build and release both with and without the raspberry feature #250

jessebraham opened this issue Oct 3, 2022 · 1 comment · Fixed by #255
Assignees
Labels
CI Continuous integration/deployment
Milestone

Comments

@jessebraham
Copy link
Member

Presently the raspberry feature is not enabled in our CI workflow. Since we're unable to test builds for this without actually doing so on a Pi (or messing around with cross-compilation) it'd be best if we could check this automatically.

@jessebraham jessebraham added the CI Continuous integration/deployment label Oct 3, 2022
@jessebraham jessebraham added this to the v2 milestone Oct 3, 2022
@SergioGasquez
Copy link
Member

SergioGasquez commented Oct 5, 2022

Hi! After some evaluation I found the following options:

  1. Have the package and rust checks into the same file for raspberry targets.
    • This felt weird as raspberry targets had a single file for rust and package while the others targets had two.
  2. Use a single file for Raspberry targets as in the first option, but merge the current rust.yml with the current package.yml, so that non-raspberry targets have also a single file.
    • Files become harder to read.
  3. Split raspberry stuff into two files: One for rust checks and another for creating release packages, as we do for other targets.
    • It maintains the way files were organized and keeps the files relatively simple. There are still some differences between Raspberry targets and others, for example, rust checks for raspberry targets are executed in a matrix, while for the other targets they are not.

I went for option 3 in #255, but I am happy to change to any of the other options (it may not be on my list).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration/deployment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants