Skip to content

Commit f6f2cee

Browse files
github-actions[bot]ESLint Bot
and
ESLint Bot
authored
Add TSC meeting 31-October-2024 transcript (#545)
Co-authored-by: ESLint Bot <eslint[bot]@users.noreply.github.com>
1 parent 0d5c59d commit f6f2cee

File tree

1 file changed

+158
-0
lines changed

1 file changed

+158
-0
lines changed

notes/2024/2024-10-31-transcript.md

+158
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,158 @@
1+
# 10/31/2024 ESLint TSC Meeting Transcript
2+
3+
**nzakas:** Howdy!
4+
5+
**mdjermanovic:** Hi!
6+
7+
**fasttime:** Hi!
8+
9+
**nzakas:** Pulling up last meeting's notes
10+
11+
**nzakas:** Okay, looks like no action items to follow up on, so let's do status updates. For me, I've been working on the CSS plugin and adding concurrency for the `readFile` retrier.
12+
13+
**mdjermanovic:** I was working on config loader caching, new syntax, and spent a lot of time reviewing the `meta.defaultOptions` PR as it updates the core and 70+ rules.
14+
15+
**fasttime:** I did the release, completed https://github.com/eslint/rewrite/pull/59 and continued working on fixing drive letter handing on Windows in ESLint. Also did some repo maintenance to fix the build and updated dependencies.
16+
17+
**nzakas:** Let's review RFC duty next
18+
19+
**nzakas:** This week: @mdjermanovic
20+
November 4: @fasttime
21+
November 11: @nzakas
22+
November 18: @mdjermanovic
23+
* 👍 @mdjermanovic, @fasttime
24+
25+
**nzakas:** It looks like we don't have any issues tagged for this meeting. Are there any issues or PRs anyone would like to discuss?
26+
27+
**fasttime:** Nothing from me.
28+
29+
**mdjermanovic:** Nothing in particular
30+
31+
**nzakas:** Okay, I'll just call out that the PR for the CSS plugin is ready for review: https://github.com/eslint/css/pull/2
32+
* 👍 @mdjermanovic, @fasttime
33+
34+
**nzakas:** Definitely interesting working in another AST format. 😄
35+
36+
**mdjermanovic:** I'll take a look this weekend or early next week
37+
* 🙏 @nzakas
38+
39+
**fasttime:** thanks!
40+
41+
**nzakas:** Just looking through the triage board to see if anything jumps out as needing discussion
42+
43+
**fasttime:** just noting that someone posted a reply on https://github.com/eslint/eslint/discussions/18957
44+
* 👀 @nzakas
45+
46+
**nzakas:** Maybe we can decide on this one? https://github.com/eslint/eslint/issues/19022
47+
48+
**nzakas:** The ever-complicated `require-atomic-updates`
49+
50+
**nzakas:** It seems that `this` is excepted from the rule, and the question is whether or not that should be the case. If not, should it be a change of default or a new option?
51+
52+
**fasttime:** I think it's okay to add a new option to not break existing projects, but would like another opinion if it makes sense to report on `this` in the first place.
53+
54+
**mdjermanovic:** Yeah, I think it's a bug that `this` is omitted. So this is a valid request. But given that the way this rule works with properties is "controversial" (there were many reports for false positives) and the complexity required to support `this` (as it's not handled by scope manager) I'm 50/50 on accepting/wontfix.
55+
56+
**mdjermanovic:** If we do accept, I think it should be behind an option
57+
58+
**nzakas:** @mdjermanovic can you explain a bit more about the complexity of implementing this? I'm just wondering if the effort-value tradeoff is worth it.
59+
60+
**mdjermanovic:** Variables are tracked by the scope manager, the rule has references and other things "for free". For `this`, I believe the rule should implement its own tracking.
61+
62+
**nzakas:** And what's the effort for that?
63+
64+
**mdjermanovic:** I don't have an estimate at the moment, but the fix certainly wouldn't be trivial.
65+
66+
**nzakas:** In that case, I'd vote either for wontfix or accepting for outside contributions. We have too many other higher-priority things to work on at the moment.
67+
68+
**nzakas:** It's not something I'd want to see us spending much time on.
69+
70+
**fasttime:** The OP checked the box to say he would like to submit a pull request.
71+
72+
**fasttime:** We could ask him if he's still willing to work on it.
73+
74+
**mdjermanovic:** I'm fine with accepting. Would be fine with wontfix as well 🙂 so whichever you are in favor
75+
76+
**fasttime:** I'm also in favor of accepting or not fixing.
77+
78+
**nzakas:** I question whether the OP actually understands what it would mean to implement the fix and whether or not we'd get pulled into handholding on the PR. So my vote is wontfix.
79+
80+
**mdjermanovic:** Sounds like a tiebreaker for wontfix then.
81+
82+
**fasttime:** Okay for me 👍
83+
84+
**nzakas:** Okay, we've decided to close as wontfix.
85+
* 👍 @mdjermanovic, @fasttime
86+
87+
**nzakas:** Okay, last call for other issues or PRs to discuss?
88+
89+
**mdjermanovic:** Nothing for today from me
90+
91+
**fasttime:** Nothing else
92+
93+
**nzakas:** Do we want to do contributor pool today since it's the last day of October?
94+
* 👍 @fasttime
95+
96+
**mdjermanovic:** Sounds good to me.
97+
98+
**nzakas:** https://github.com/issues?q=org%3Aeslint+label%3A%22contributor+pool%22+merged%3A2024-10-01..2024-10-31
99+
100+
**nzakas:** Do any of these rise above $100?
101+
102+
**nzakas:** (I wasn't really involved in most of these so not enough context.)
103+
104+
**mdjermanovic:** The new syntax PR I think
105+
106+
**fasttime:** I'm not sure about https://github.com/eslint/js/pull/639
107+
108+
**mdjermanovic:** ota-meshi also did all the work in `acorn` and `regexpp`
109+
110+
**fasttime:** for the rest $100 is fine
111+
112+
**nzakas:** So $500 for ota-meshi?
113+
* 👍 @mdjermanovic, @fasttime
114+
115+
**nzakas:** All right, I'll let them know.
116+
117+
**nzakas:** let's talk about the release
118+
119+
**mdjermanovic:** I can tomorrow
120+
* 🙏 @nzakas, @fasttime
121+
122+
**mdjermanovic:** Since there is a change request on the `meta.defaultOptions` PR, I think we'll have just `eslint` and `@eslint/js` releases tomorrow (otherwise, it would be `@eslint/eslintrc` as well).
123+
* 👍 @nzakas, @fasttime
124+
125+
**nzakas:** It looks like `@eslint/json` and `@eslint/create-config` have releases pending too.
126+
127+
**nzakas:** Shall we publish those as well?
128+
129+
**mdjermanovic:** If this can be merged, it would be great since we've already enabled parsing support: https://github.com/eslint/eslint/pull/19076
130+
* 👍 @nzakas
131+
132+
**mdjermanovic:** Yes, I can publish those two after the meeting.
133+
* 👍 @fasttime
134+
135+
**nzakas:** And we can do the more extended highlights section on the blog. 😄
136+
* 👍 @fasttime
137+
138+
**mdjermanovic:** Oh, I've already prepared that
139+
* 🎉 @nzakas
140+
141+
**nzakas:** After the release, I think it would be helpful to compare the runtime of v9.12.0 to v9.14.0 since we'll have implemented two perf improvements (compile cache and config array caching).
142+
* 👍 @mdjermanovic
143+
144+
**nzakas:** At least for me, the compile cache alone reduced linting `eslint/eslint` from about 2:45 to like 1:50.
145+
* 🎉 @mdjermanovic
146+
147+
**fasttime:** I also noticed that improvement with the compile cache.
148+
149+
**nzakas:** I think this will be ready by tomorrow (will finish up tonight and tomorrow morning): https://github.com/eslint/eslint/pull/19077
150+
151+
**mdjermanovic:** I'll also ask on https://github.com/eslint/eslint/issues/19025 whether they notice better performance with 9.14.0
152+
* 👍 @nzakas, @fasttime
153+
154+
**nzakas:** Okay, I think that's it for today. Thanks everyone (and thanks @sam3k_ for the notes!)
155+
156+
**mdjermanovic:** Thanks!
157+
158+
**fasttime:** Thank you 👋

0 commit comments

Comments
 (0)