|
| 1 | +# 10/17/2024 ESLint TSC Meeting Transcript |
| 2 | + |
| 3 | +**mdjermanovic:** Hi! |
| 4 | + |
| 5 | +**fasttime:** Hi 👋 |
| 6 | + |
| 7 | +**nzakas:** Howdy! |
| 8 | + |
| 9 | +**nzakas:** Just looking over the notes from last time and it doesn't look like we have any action items to follow up on . |
| 10 | + |
| 11 | +**nzakas:** So let's do statuses. I didn't do too much on account of being offline. A bit of work on `@eslint/json` to allow trailing commas in JSONC and otherwise I'm just trying to get caught up on notifications. |
| 12 | + |
| 13 | +**mdjermanovic:** I was working on `Language#defaultLanguageOptions`, fixed the `markdown/no-missing-label-refs` rule, and updated repos to use prerendered sponsors. |
| 14 | + |
| 15 | +**fasttime:** I've done the release, worked on removing jiti v1.21 and fixing Windows path handling in `config-array`, and did some minor fixes. Also triged and reviewed issues and PRs. |
| 16 | + |
| 17 | +**nzakas:** And just a quick update of RFC duty: |
| 18 | +This week: @fasttime |
| 19 | +10/21: @nzakas |
| 20 | +10/28: @mdjermanovic |
| 21 | + * 👍 @mdjermanovic, @fasttime |
| 22 | + |
| 23 | +**nzakas:** All right, it looks like we don't have anything tagged for this meeting. Any topics anyone would like to discuss? |
| 24 | + |
| 25 | +**mdjermanovic:** I have one |
| 26 | + |
| 27 | +**mdjermanovic:** Any objections or concerns about merging this? https://github.com/eslint/eslint/pull/19011 |
| 28 | + |
| 29 | +**fasttime:** No concerns from my side. |
| 30 | + |
| 31 | +**nzakas:** No objections |
| 32 | + |
| 33 | +**mdjermanovic:** Okay, then I'm going to merge it |
| 34 | + * 👍 @nzakas, @fasttime |
| 35 | + |
| 36 | +**nzakas:** Just looking through some open issues... |
| 37 | + |
| 38 | +**nzakas:** This one has been "tsc waiting" for a bit: https://github.com/eslint/js/issues/623 |
| 39 | + |
| 40 | +**nzakas:** This asks to expose the Acorn plugin from Espree. While I'm not in favor of exposing it via the `espree` package, I'm starting to think it could be beneficial to expose it through another package. |
| 41 | + |
| 42 | +**nzakas:** Basically, as a toolkit for people who want to customize Acorn and still have it usable through ESLint. |
| 43 | + |
| 44 | +**nzakas:** I ran into this experimenting with a TypeScript Acorn plugin, where I ended up needing to re-implement a lot of the fixes that Espree does to the AST. |
| 45 | + |
| 46 | +**mdjermanovic:** So, that would also be useful for us if we decide to make a TypeScript parser? |
| 47 | + |
| 48 | +**nzakas:** Yes. Or if someone else does. |
| 49 | + |
| 50 | +**mdjermanovic:** I'm generally in favor. I'll look into details posted on the issue over the weekend |
| 51 | + |
| 52 | +**nzakas:** Sounds good. |
| 53 | + |
| 54 | +**fasttime:** I'm also in favor, but still not sure what needs to be done. If @mdjermanovic wants to take a look that would be great. |
| 55 | + |
| 56 | +**nzakas:** Great, we'll follow up on the issue. |
| 57 | + |
| 58 | +**nzakas:** Just to check in on this issue: https://github.com/eslint/eslint/issues/18621 |
| 59 | + |
| 60 | +**nzakas:** I believe everything is complete and we can close this? |
| 61 | + |
| 62 | +**nzakas:** (The last step was deprecating old packages.) |
| 63 | + |
| 64 | +**mdjermanovic:** Yes, I also believe all tasks are done |
| 65 | + |
| 66 | +**fasttime:** Sounds good to close |
| 67 | + |
| 68 | +**nzakas:** Great, closed! |
| 69 | + * 👍 @mdjermanovic |
| 70 | + |
| 71 | +**nzakas:** Any other topics to discuss? |
| 72 | + |
| 73 | +**fasttime:** Nothing from my side |
| 74 | + |
| 75 | +**mdjermanovic:** Nothing in particular from my side for today |
| 76 | + |
| 77 | +**nzakas:** And it looks like the v8 EOL stuff was all completed too. Will be interested to see if HeroDevs gets any business from that. |
| 78 | + |
| 79 | +**nzakas:** Let's talk about the release. |
| 80 | + |
| 81 | +**fasttime:** I can do the release tomorrow |
| 82 | + |
| 83 | +**mdjermanovic:** Thanks! |
| 84 | + |
| 85 | +**nzakas:** Thanks! |
| 86 | + |
| 87 | +**fasttime:** Shall we release also `@eslint/core` and update the dependency in eslint? |
| 88 | + * 👍 @nzakas |
| 89 | + |
| 90 | +**mdjermanovic:** If https://github.com/eslint/eslint/pull/19003 gets merged for tomorrow's release, I think yes. |
| 91 | + |
| 92 | +**mdjermanovic:** I'm only not sure if we want to release packages that only had dev deps update: https://github.com/eslint/rewrite/pull/124 |
| 93 | + |
| 94 | +**mdjermanovic:** I don't know why release-please works that way. Didn't find an option to change that behavior |
| 95 | + |
| 96 | +**nzakas:** That is strange. 🤔 It probably figures that you always want to keep the published versions of all packages in a monorepo in sync. |
| 97 | + |
| 98 | +**mdjermanovic:** Yeah, it seems useful to update dev deps. I just wouldn't expect bumping and releasing versions because of it |
| 99 | + |
| 100 | +**nzakas:** Agreed. Unfortunately, it doesn't seem like we have a choice. I think the only way out of it would be to update `release-please-config.json` to have separate PRs for each package. |
| 101 | + |
| 102 | +**mdjermanovic:** Seems like it treats devDependecies the same as dependencies |
| 103 | + |
| 104 | +**mdjermanovic:** Temporarily for this release, or always? |
| 105 | + |
| 106 | +**nzakas:** Well, anytime we want to not publish one package because of a dev dep upgrade. So if that's always the case, then we'd need it in there permanently (unless release-please makes a change). |
| 107 | + |
| 108 | +**nzakas:** I'm generally not a fan of having separate PRs for each package as I think most of the time we want to publish multiple at once, but I'm not completely against it. |
| 109 | + |
| 110 | +**mdjermanovic:** I'm also not very much in favor. It's usually quite useful to release all at once and automatically update dependencies |
| 111 | + |
| 112 | +**nzakas:** May be worth opening an issue on release-please? Won't help for this week, but maybe something can be done. |
| 113 | + |
| 114 | +**fasttime:** So shall we release all packages? Or update the release-please config temporarily to only release `@eslint/core`? |
| 115 | + |
| 116 | +**mdjermanovic:** I think it would be good if we find an option to temporarily make it release just `@eslint/core` and then switch it back |
| 117 | + |
| 118 | +**mdjermanovic:** Or just release all packages 🙂 |
| 119 | + |
| 120 | +**nzakas:** I'd say just release all the packages. It'll create some Twitter noise but jumping through hoops for this doesn't seem like a good use of time. |
| 121 | + * 👍 @mdjermanovic, @fasttime |
| 122 | + |
| 123 | +**fasttime:** Agreed. I'll release `eslint/rewrite` if the PR is merged by tomorrow. |
| 124 | + * 👍 @nzakas, @mdjermanovic |
| 125 | + |
| 126 | +**nzakas:** Okay, I'll review the PR after this meeting. |
| 127 | + * 👍 @mdjermanovic |
| 128 | + |
| 129 | +**fasttime:** Thanks! |
| 130 | + |
| 131 | +**mdjermanovic:** Thanks! |
| 132 | + |
| 133 | +**nzakas:** Does anyone want to file an issue with release-please? |
| 134 | + |
| 135 | +**mdjermanovic:** I'll file an issue |
| 136 | + |
| 137 | +**nzakas:** Thanks! |
| 138 | + |
| 139 | +**fasttime:** Thanks! |
| 140 | + |
| 141 | +**nzakas:** Okay, I think that's all for today. Thanks everyone! (And thanks @sam3k_ for the notes) |
| 142 | + |
| 143 | +**mdjermanovic:** Thanks! 👋 |
| 144 | + |
| 145 | +**fasttime:** Thanks everybody, bye! |
0 commit comments