feat: export MarkdownRuleDefinition type
#333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR exports the MarkdownRuleDefinition type to make it available for consumers, ensuring type consistency across rule definitions.
- Adds an import for MarkdownRuleDefinition in the test suite.
- Updates typedefs in src/index.js to support generic usage of MarkdownRuleDefinition.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/types/types.test.ts | Adds type tests to validate MarkdownRuleDefinition compatibility tests. |
| src/index.js | Updates JSDoc typedefs to export and accurately type MarkdownRuleDefinition with generics. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports the type definition for
MarkdownRuleDefinition, making it accessible to consumers.refs eslint/eslint#19521