feat: added new rule table-column-count #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
May 25, 2025
Contributor
snitin315
left a comment
snitin315
left a comment
There was a problem hiding this comment.
This looks like a good start, I have a few suggestions.
snitin315
reviewed
May 25, 2025
lumirlumir
requested changes
May 26, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
Nice rule👍 I've left a few comments.
snitin315
previously approved these changes
May 29, 2025
Contributor
snitin315
left a comment
snitin315
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Leaving it open for @lumirlumir
Contributor
Author
|
@lumirlumir Can you please review the PR |
Member
|
@SwetaTanwar please give folks a couple days to circle back to your PR. We have a lot that we're reviewing at any time. |
lumirlumir
requested changes
May 31, 2025
lumirlumir
approved these changes
Jun 1, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your hard work!
Would like @snitin315 to verify the changes before merging.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR adds a new rule
table-column-countto disallow data rows in a GitHub Flavored Markdown table from having more cells than the header rowWhat changes did you make? (Give an overview)
Added the
table-column-countrule, along with documentation and tests.Related Issues
fixes #389
Is there anything you'd like reviewers to focus on?