-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add support for getLocFromIndex and getIndexFromLoc
#109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mdjermanovic
merged 8 commits into
main
from
feat-add-support-for-getlocfromindex-and-getindexfrom-loc
Sep 24, 2025
Merged
feat: add support for getLocFromIndex and getIndexFromLoc
#109
mdjermanovic
merged 8 commits into
main
from
feat-add-support-for-getlocfromindex-and-getindexfrom-loc
Sep 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
1 task
1 task
mdjermanovic
approved these changes
Sep 24, 2025
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've updated the
@eslint/plugin-kitand@eslint/coredependencies to add support for thegetLocFromIndexandgetIndexFromLocmethods.Since these methods were already well tested in the
rewriterepository, I've only added a few simple tests to verify their behavior.What changes did you make? (Give an overview)
In this PR, I've updated the
@eslint/plugin-kitand@eslint/coredependencies to add support for thegetLocFromIndexandgetIndexFromLocmethods.Related Issues
Ref: eslint/rewrite#212
Is there anything you'd like reviewers to focus on?
N/A