chore: remove unused dev dependencies from packages #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
commented
Sep 17, 2025
| @@ -1,4 +1,4 @@ | |||
| import { expectType, expectAssignable, expectError } from 'tsd'; | |||
| import { expectType, expectAssignable } from 'tsd'; | |||
Member
Author
There was a problem hiding this comment.
expectError was unused, so I've removed it.
lumirlumir
changed the title
eslint-visitor-keys
mdjermanovic
deleted the
chore-remove-unused-dev-dependencies-from-eslint-visitor-keys
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I removed unused devDependencies from the
eslint-visitor-keysandespreepackages.I've looked through the package, and it appears that
@types/estree,@types/estree-jsx,@typescript-eslint-parser, andesqueryweren't used anywhere in theeslint-visitor-keyspackage.Also, it seems that
esprima-fbis a legacy dev dependency and was never used anywhere except being mentioned in a comment.I've also bumped the other dev-dependencies to their latest versions.
What changes did you make? (Give an overview)
In this PR, I removed unused devDependencies from the
eslint-visitor-keysandespreepackages.Related Issues
Ref: #689
Is there anything you'd like reviewers to focus on?
I think most of the dev dependencies are legacy and can safely be removed, since they aren't used anywhere and the CI is passing.