Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Nov 1, 2025

Prerequisites checklist

What is the purpose of this pull request?

Updates the ESLint configuration to use the latest eslint-plugin-react-hooks setup, which no longer includes the react-hooks/react-compiler rule.

What changes did you make? (Give an overview)

  • Upgraded eslint-plugin-react-hooks from ^6.0.0-rc.1 to ^7.0.1.
  • Removed the react-hooks/react-compiler rule, which was split into individual rules.
  • Switched to reactHooksPlugin.configs.flat.recommended for a cleaner and up-to-date configuration.
  • Updated React and React DOM from 19.1.0 to 19.2.0.
  • Replaced the impure Date.now() call inside the render phase with a deterministic key generation approach for Alert components, prompted by the new react-hooks/purity rule.

Related Issues

Closes #809

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 1, 2025
@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/690625c51f28ad0008659cc9
😎 Deploy Preview https://deploy-preview-832--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/690625c55efac30008cf81a7
😎 Deploy Preview https://deploy-preview-832--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/690625c567e9b80008d55fac
😎 Deploy Preview https://deploy-preview-832--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot mentioned this pull request Nov 1, 2025
1 task
@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/690625c50330c2000840fb52
😎 Deploy Preview https://deploy-preview-832--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/690625c5ea638600088c29ad
😎 Deploy Preview https://deploy-preview-832--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/690625c544978f000892999c
😎 Deploy Preview https://deploy-preview-832--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/690625c5c90f7a0008817051
😎 Deploy Preview https://deploy-preview-832--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 3377634
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/690625c546c66500082f4c7a
😎 Deploy Preview https://deploy-preview-832--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.
For the next time please focus the PR on one thing (here you updated dependencies and changed code), this allows better history tracking.
Leaving this open for 2 days if someone else wants to look over.

@DMartens DMartens moved this from Needs Triage to Second Review Needed in Triage Nov 3, 2025
@Pixel998
Copy link
Contributor Author

Pixel998 commented Nov 3, 2025

Thanks for the review. The code change was required by the updated dependency. The new react-hooks/purity rule in eslint-plugin-react-hooks flagged the Date.now() usage, so I fixed it as part of the same PR.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@amareshsm amareshsm merged commit 6e65ec0 into main Nov 3, 2025
37 checks passed
@amareshsm amareshsm deleted the update-react-monorepo branch November 3, 2025 18:46
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants