-
-
Notifications
You must be signed in to change notification settings - Fork 75
chore: update react monorepo #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DMartens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks.
For the next time please focus the PR on one thing (here you updated dependencies and changed code), this allows better history tracking.
Leaving this open for 2 days if someone else wants to look over.
|
Thanks for the review. The code change was required by the updated dependency. The new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Prerequisites checklist
What is the purpose of this pull request?
Updates the ESLint configuration to use the latest
eslint-plugin-react-hookssetup, which no longer includes thereact-hooks/react-compilerrule.What changes did you make? (Give an overview)
eslint-plugin-react-hooksfrom^6.0.0-rc.1to^7.0.1.react-hooks/react-compilerrule, which was split into individual rules.reactHooksPlugin.configs.flat.recommendedfor a cleaner and up-to-date configuration.19.1.0to19.2.0.Date.now()call inside the render phase with a deterministic key generation approach forAlertcomponents, prompted by the newreact-hooks/purityrule.Related Issues
Closes #809
Is there anything you'd like reviewers to focus on?