Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: npm prepare script on Windows (refs #166) #168

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Fix: npm prepare script on Windows (refs #166) #168

merged 4 commits into from
Dec 20, 2020

Conversation

btmills
Copy link
Member

@btmills btmills commented Dec 16, 2020

#166 originally reported being unable to npm install in the repository on Windows. This was due to the changes in #164, which worked fine on Linux and macOS but not Windows. This PR first adds macOS and Windows to the test matrix and then fixes the npm prepare script by moving the previous bash-only logic into JS.

The previous script worked on macOS and Linux, but I neglected to
consider Windows. This wouldn't affect users thankfully, only
developers, so the blast radius would have been small had it not been
caught. Now that we're testing on Windows, future bugs like this should
be caught. I'm out of ideas for doing this entirely inside npm scripts,
so I broke down and did it in JS.
@btmills btmills changed the title Chore: Test on Windows and macOS Fix: npm prepare script on Windows (refs #166) Dec 16, 2020
They occasionally exhibit extremely slow filesystem performance.
@btmills btmills marked this pull request as ready for review December 16, 2020 07:53
npm-prepare.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants