Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't require message end locations (fixes #112) #154

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Conversation

btmills
Copy link
Member

@btmills btmills commented Jul 20, 2020

Issue #112 reported VSCode drawing squigglies all the way from the top of a file to a line in a code block with a syntax error rather than just squigglying the line with the syntax error. For messages that only specified start locations, the processor was adding endLine: NaN.

Issue #112 reported VSCode drawing squigglies all the way from the top
of a file to a line in a code block with a syntax error rather than just
squigglying the line with the syntax error. For messages that only
specified start locations, the processor was adding `endLine: NaN`.
Copy link

@rocketkai rocketkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants