Skip to content

Commit d94c22f

Browse files
authored
Build: Install example test dependencies in Jenkins (#160)
The 2.0.0-rc.0 release attempt failed when trying to run the examples' tests because their dependencies were never installed. In #152, I added an install step to the GitHub Actions workflow but not the Jenkins release flow. This change adds an `install-examples` npm script and calls it both from the GitHub Actions workflow and the `generate-.*release` scripts.
1 parent 7f26cb9 commit d94c22f

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,7 @@ jobs:
3636
with:
3737
node-version: ${{ matrix.node-version }}
3838
- name: Install Packages
39-
run: npm install
40-
env:
41-
CI: true
42-
- name: Install examples/react Packages
43-
working-directory: ./examples/react
44-
run: npm install
45-
env:
46-
CI: true
47-
- name: Install examples/typescript Packages
48-
working-directory: ./examples/typescript
49-
run: npm install
39+
run: npm install && npm run install-examples
5040
env:
5141
CI: true
5242
- name: Test

package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@
2020
"linter"
2121
],
2222
"scripts": {
23+
"install-examples": "for example in examples/*; do (cd \"$example\" && npm install); done",
2324
"lint": "eslint --ext js,md .",
2425
"test": "npm run lint && npm run test-cov",
2526
"test-cov": "nyc _mocha -- -c tests/{examples,lib}/**/*.js",
26-
"generate-release": "eslint-generate-release",
27-
"generate-alpharelease": "eslint-generate-prerelease alpha",
28-
"generate-betarelease": "eslint-generate-prerelease beta",
29-
"generate-rcrelease": "eslint-generate-prerelease rc",
27+
"generate-release": "npm run install-examples && eslint-generate-release",
28+
"generate-alpharelease": "npm run install-examples && eslint-generate-prerelease alpha",
29+
"generate-betarelease": "npm run install-examples && eslint-generate-prerelease beta",
30+
"generate-rcrelease": "npm run install-examples && eslint-generate-prerelease rc",
3031
"publish-release": "eslint-publish-release"
3132
},
3233
"main": "index.js",

0 commit comments

Comments
 (0)