Skip to content

feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24 #90

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4bec812
feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24
aladdin-add Oct 14, 2025
de1a883
Update Node.js engine version requirements
aladdin-add Oct 14, 2025
9d08cb1
update CI workflows to drop Node.js 18
aladdin-add Oct 17, 2025
210a40c
Update Node.js version in build workflow
aladdin-add Oct 27, 2025
b44acb5
Update Node.js version in build workflow
aladdin-add Oct 27, 2025
21ad86a
Update Node.js versions in build workflow
aladdin-add Oct 27, 2025
f699362
Change Node.js version from 24 to 20
aladdin-add Oct 27, 2025
1921bec
Upgrade Node.js version to 24 in build.yml
aladdin-add Oct 27, 2025
17ab26a
Refactor Node.js version matrix in build.yml
aladdin-add Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,10 @@ jobs:
matrix:
os: [ubuntu-latest]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
node_version:
- 10
- 12.20.0
- 14.13.0
- 16
- 18
- 20
- 22
- 24
- 25
node: [25.x, 24.x, 22.x, 20.x, "20.19.0"]
Copy link
Member

@fasttime fasttime Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think PRIMARY_NODEJS_VERSION should be also changed to match one of the values in this list.

csstree/.github/workflows/build.yml

Line 8 in 9d08cb1

PRIMARY_NODEJS_VERSION: 20

That could fix the CI failure, or result in a different error.

include:
- os: windows-latest
node: 10
- os: windows-latest
node: 22
node: lts/*

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"typescript": "^5.7.3"
},
"engines": {
"node": "^10 || ^12.20.0 || ^14.13.0 || >=15.0.0"
"node": "^20.19.0 || ^22.13.0 || >=24"
},
"files": [
"data",
Expand Down