Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Jun 8, 2025

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've updated the @eslint/plugin-kit and @eslint/core dependencies to add support for the getLocFromIndex and getIndexFromLoc methods.

Since these methods were already well tested in the rewrite repository, I've only added a few simple tests to verify their behavior.

What changes did you make? (Give an overview)

In this PR, I've updated the @eslint/plugin-kit and @eslint/core dependencies to add support for the getLocFromIndex and getIndexFromLoc methods.

Related Issues

Ref: eslint/rewrite#212

Is there anything you'd like reviewers to focus on?

N/A

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 8, 2025
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Jun 18, 2025
@github-actions
Copy link
Contributor

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Aug 13, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 15, 2025
@lumirlumir lumirlumir marked this pull request as ready for review September 23, 2025 12:44
@lumirlumir lumirlumir requested a review from a team September 23, 2025 12:44
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 3baeacf into main Sep 24, 2025
22 checks passed
@mdjermanovic mdjermanovic deleted the feat-add-support-for-getlocfromindex-and-getindexfromloc branch September 24, 2025 06:41
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion feature Stale

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants