-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yarn and pnpm support in eslint --init #20
Comments
Thanks for the issue. I think we can ask the user itself which package manager to use. That means one more prompt. |
Re-evaluating this now seems prudent, but please fill out the requested issue template. The current tone and state of this issue doesn't give us much room to have a discussion. |
Sorry I use reply of the comment I will edit |
@kaicataldo . I edited, Sorry for the previous tone 😕 |
Thank you. Adding a question about whether |
Can I work on this issue? |
@snitin315 I'd recommend waiting until the team has reached consensus on this feature's inclusion so that there isn't any throwaway work. That being said, a PR can sometimes make things easier to evaluate! |
Is it required for this PR to go through RFC? |
@anikethsaha This seems like a small enough change to me that it wouldn't warrant an RFC. |
I will send a PR soon then. |
TSC Summary: This proposal seeks to add a question to TSC Question: Shall we accept this proposal? |
We approved this change in today's TSC meeting. To reduce complexity, |
@btmills thanks! I will update the corresponding PR. |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
Reopening because of active PR. |
Hey , is anyone still working on this? It would be great if there is also If no one is working on this I can give it a shot. |
There is an active PR: eslint/eslint#13756 |
We have decided to postpone |
Given that the request also asked for pnpm (though I don't know if that part has been accepted), perhaps the issue can be renamed to ensure that support is also being tracked? |
Done |
Just installed eslint and ran --init. After going through the prompts it starting downloading packages without my permission from npm. I use pnpm. I'm not saying add pnpm support (pnpm auto detects if other package managers install things and will prompt to fix it) rather don't auto start the installation. Uninstalled. |
@sharedrory can you please submit a bug report with steps that lead to downloading packages without your permission? That is not intended behavior. I tried one path, and there was a step asking for confirmation to install packages with npm:
|
Any news about this? Looks like all the PRs/feats have been closed |
When there are updates they will be posted on this issue. |
Gotcha. Keeping my fingers crossed! ;) |
this is unblocked. @snitin315 are you still interested in working on this? 😄 |
@aladdin-add No, not at the moment. |
I'd like to pick this up 😄 |
name: "Add yarn support for --init"
about: Request a change that is not a bug fix, rule change, or new rule
title: 'Add yarn support for --init'
labels: enhancement, triage, core
assignees: ''
The version of ESLint you are using.
7.8.1
The problem you want to solve.
Originally posted by @ilyavolodin in eslint/eslint#9023 (comment)
The yarn is not official but is more used of NPM. And I don't see a problem on support Yarn ?? I really don't understand why closed THIS PR
Your take on the correct solution to problem.
Add yarn and pnpm support.
Are you willing to submit a pull request to implement this change?
No
The text was updated successfully, but these errors were encountered: