Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yarn and pnpm support in eslint --init #20

Closed
mateushnsoares opened this issue Sep 1, 2020 · 28 comments · Fixed by #24
Closed

Add Yarn and pnpm support in eslint --init #20

mateushnsoares opened this issue Sep 1, 2020 · 28 comments · Fixed by #24
Labels

Comments

@mateushnsoares
Copy link

mateushnsoares commented Sep 1, 2020


name: "Add yarn support for --init"
about: Request a change that is not a bug fix, rule change, or new rule
title: 'Add yarn support for --init'
labels: enhancement, triage, core
assignees: ''


The version of ESLint you are using.

7.8.1

The problem you want to solve.

I'm 👎 on adding this in. Yarn is a popular package manager, but it's not an official one. There're a bunch of other package managers out there. If the user chose to use yarn as an NPM replacement (which is perfectly fine), they should be ready to do some tweaking by hands.

Originally posted by @ilyavolodin in eslint/eslint#9023 (comment)

The yarn is not official but is more used of NPM. And I don't see a problem on support Yarn ?? I really don't understand why closed THIS PR

Your take on the correct solution to problem.

Add yarn and pnpm support.

Are you willing to submit a pull request to implement this change?

No

@anikethsaha
Copy link
Member

Thanks for the issue.

I think we can ask the user itself which package manager to use. That means one more prompt.

@anikethsaha anikethsaha added cli enhancement New feature or request and removed triage labels Sep 1, 2020
@kaicataldo
Copy link
Member

Re-evaluating this now seems prudent, but please fill out the requested issue template. The current tone and state of this issue doesn't give us much room to have a discussion.

@mateushnsoares
Copy link
Author

Sorry I use reply of the comment I will edit

@mateushnsoares
Copy link
Author

@kaicataldo . I edited, Sorry for the previous tone 😕

@kaicataldo
Copy link
Member

Thank you. Adding a question about whether yarn or npm should be used in --init makes sense to me.

@snitin315
Copy link
Contributor

Can I work on this issue?

@kaicataldo
Copy link
Member

@snitin315 I'd recommend waiting until the team has reached consensus on this feature's inclusion so that there isn't any throwaway work. That being said, a PR can sometimes make things easier to evaluate!

@anikethsaha
Copy link
Member

Is it required for this PR to go through RFC?

@kaicataldo
Copy link
Member

@anikethsaha This seems like a small enough change to me that it wouldn't warrant an RFC.

@snitin315
Copy link
Contributor

I will send a PR soon then.

@nzakas
Copy link
Member

nzakas commented Oct 31, 2020

TSC Summary: This proposal seeks to add a question to --init asking if dependencies should be installed with npm or yarn.

TSC Question: Shall we accept this proposal?

@btmills
Copy link
Member

btmills commented Nov 20, 2020

We approved this change in today's TSC meeting. To reduce complexity, --init shouldn't try to guess the correct package manager. It should ask Which package manager does your project use? with npm as the default and yarn as an option. @snitin315 hopefully that's the answer you needed to finish up eslint/eslint#13756! 🚀

@snitin315
Copy link
Contributor

@btmills thanks! I will update the corresponding PR.

@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that accepted issues failing to be implemented after 90 days tend to
never be implemented, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@nzakas
Copy link
Member

nzakas commented Dec 22, 2020

Reopening because of active PR.

@nzakas nzakas reopened this Dec 22, 2020
@ashishbinu
Copy link

Hey , is anyone still working on this? It would be great if there is also pnpm support along with yarn.

If no one is working on this I can give it a shot.

@nzakas
Copy link
Member

nzakas commented Apr 21, 2021

There is an active PR: eslint/eslint#13756

@mdjermanovic
Copy link
Member

We have decided to postpone yarn support until the --init functionality gets extracted into a separate package (eslint/rfcs#58), for the reasons described in eslint/eslint#13756.

@brettz9
Copy link

brettz9 commented Jul 23, 2021

Given that the request also asked for pnpm (though I don't know if that part has been accepted), perhaps the issue can be renamed to ensure that support is also being tracked?

@nzakas nzakas changed the title Add Yarn in eslint --init Add Yarn and pnpm support in eslint --init Jul 24, 2021
@nzakas
Copy link
Member

nzakas commented Jul 24, 2021

Done

@ghost
Copy link

ghost commented Sep 11, 2021

Just installed eslint and ran --init. After going through the prompts it starting downloading packages without my permission from npm. I use pnpm. I'm not saying add pnpm support (pnpm auto detects if other package managers install things and will prompt to fix it) rather don't auto start the installation. Uninstalled.

@mdjermanovic
Copy link
Member

Just installed eslint and ran --init. After going through the prompts it starting downloading packages without my permission from npm. I use pnpm. I'm not saying add pnpm support (pnpm auto detects if other package managers install things and will prompt to fix it) rather don't auto start the installation. Uninstalled.

@sharedrory can you please submit a bug report with steps that lead to downloading packages without your permission?

That is not intended behavior. I tried one path, and there was a step asking for confirmation to install packages with npm:

√ How would you like to use ESLint? · style
√ What type of modules does your project use? · esm
√ Which framework does your project use? · react
√ Does your project use TypeScript? · No / Yes
√ Where does your code run? · browser
√ How would you like to define a style for your project? · guide
√ Which style guide do you want to follow? · airbnb
√ What format do you want your config file to be in? · JavaScript
Checking peerDependencies of eslint-config-airbnb@latest
The config that you've selected requires the following dependencies:

eslint-plugin-react@^7.21.5 eslint-config-airbnb@latest eslint@^5.16.0 || ^6.8.0 || ^7.2.0 eslint-plugin-import@^2.22.1 eslint-plugin-jsx-a11y@^6.4.1 eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0
? Would you like to install them now with npm? » No / Yes

@stereokai
Copy link

Any news about this? Looks like all the PRs/feats have been closed

@nzakas
Copy link
Member

nzakas commented Feb 5, 2022

When there are updates they will be posted on this issue.

@nzakas nzakas transferred this issue from eslint/eslint Feb 5, 2022
@stereokai
Copy link

Gotcha. Keeping my fingers crossed! ;)

@aladdin-add
Copy link
Member

this is unblocked.

@snitin315 are you still interested in working on this? 😄

@snitin315
Copy link
Contributor

@aladdin-add No, not at the moment.

@harish-sethuraman
Copy link
Member

I'd like to pick this up 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project