Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow for misconfigured default exports #288

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

scagood
Copy link

@scagood scagood commented Jun 5, 2024

fixes #242

This simply adds a test to show that incorrectly configured exports don't get classed as "missing"

@scagood scagood requested a review from aladdin-add June 5, 2024 08:22
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 💯

@aladdin-add aladdin-add merged commit 92e18b5 into eslint-community:master Jun 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no-missing-require incorrectly flagging module as missing
2 participants