Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More es-syntax deprecations #249

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: More es-syntax deprecations #249

merged 1 commit into from
Apr 17, 2024

Conversation

scagood
Copy link

@scagood scagood commented Apr 17, 2024

I think this is what we need to do for #248

@scagood scagood linked an issue Apr 17, 2024 that may be closed by this pull request
@aladdin-add
Copy link

is there something needed (as it's marking as a draft)?

@scagood
Copy link
Author

scagood commented Apr 17, 2024

Oh, sorry, this was because I changed these on my phone, and I did not trust that I had done it right!

I wanted to check on my pc :)

@scagood scagood marked this pull request as ready for review April 17, 2024 08:42
@aladdin-add
Copy link

well, LGTM! but left it open to you to do a double-check. :)

@scagood
Copy link
Author

scagood commented Apr 17, 2024

Just checked, and it's all as I'd expect :)
image

@scagood scagood merged commit 2ecee79 into master Apr 17, 2024
19 checks passed
@scagood scagood deleted the es-syntax-deprecations branch April 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate line with line 135
2 participants