Fix duplicate keys exception

CHANGELOG.md

@@ -8,6 +8,10 @@ The format is based on [Keep a Changelog][Keep a Changelog] and this project adh
 
 ## [Released]
 
+## [2.2.2] - 2022-11-11
+
+- `FindAllGamesById` will no longer throw an exception for duplicate IDs
+
 ## [2.2.1] - 2022-10-21
 
 Small update that changes the equality comparer of the dictionary returned by `EGSHandler.FindAllGamesById` and `OriginHandler.FindAllGamesById` to `StringComparer.OrdinalIgnoreCase`.

GameFinder.Common/Extensions.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using JetBrains.Annotations;
 
@@ -62,4 +63,34 @@ public static (TGame[] games, string[] errors) SplitResults<TGame>(
 
         return (games, errors);
     }
+
+    /// <summary>
+    /// Custom <see cref="Enumerable.ToDictionary{TSource,TKey}(System.Collections.Generic.IEnumerable{TSource},System.Func{TSource,TKey})"/>
+    /// function that skips duplicate keys.
+    /// </summary>
+    /// <param name="source"></param>
+    /// <param name="keySelector"></param>
+    /// <param name="elementSelector"></param>
+    /// <param name="comparer"></param>
+    /// <typeparam name="TSource"></typeparam>
+    /// <typeparam name="TKey"></typeparam>
+    /// <typeparam name="TElement"></typeparam>
+    /// <returns></returns>
+    public static Dictionary<TKey, TElement> CustomToDictionary<TSource, TKey, TElement>(
+        [InstantHandle] this IEnumerable<TSource> source, Func<TSource, TKey> keySelector,
+        Func<TSource, TElement> elementSelector, IEqualityComparer<TKey>? comparer = null)
+        where TKey: notnull
+    {
+        var dictionary = new Dictionary<TKey, TElement>(comparer);
+
+        foreach (var element in source)
+        {
+            var key = keySelector(element);
+            if (dictionary.ContainsKey(key)) continue;
+
+            dictionary.Add(key, elementSelector(element));
+        }
+
+        return dictionary;
+    }
 }

GameFinder.RegistryUtils/InMemoryRegistry.cs

@@ -105,6 +105,7 @@ internal InMemoryRegistryKey AddSubKey(RegistryHive hive, string key)
     /// <param name="value"></param>
     public void AddValue(string valueName, object value)
     {
+        if (_values.ContainsKey(valueName)) return;
         _values.Add(valueName, value);
     }
 

GameFinder.StoreHandlers.EGS/EGSHandler.cs

@@ -97,7 +97,7 @@ public override Dictionary<string, EGSGame> FindAllGamesById(out string[] errors
         var (games, allErrors) = FindAllGames().SplitResults();
         errors = allErrors;
 
-        return games.ToDictionary(game => game.CatalogItemId, game => game, StringComparer.OrdinalIgnoreCase);
+        return games.CustomToDictionary(game => game.CatalogItemId, game => game, StringComparer.OrdinalIgnoreCase);
     }
 
     private Result DeserializeGame(IFileInfo itemFile)

GameFinder.StoreHandlers.GOG/GOGHandler.cs

@@ -79,7 +79,7 @@ public override Dictionary<long, GOGGame> FindAllGamesById(out string[] errors)
         var (games, allErrors) = FindAllGames().SplitResults();
         errors = allErrors;
 
-        return games.ToDictionary(game => game.Id, game => game);
+        return games.CustomToDictionary(game => game.Id, game => game);
     }
 
     private static Result ParseSubKey(IRegistryKey gogKey, string subKeyName)

GameFinder.StoreHandlers.Origin/OriginHandler.cs

@@ -90,7 +90,7 @@ public override Dictionary<string, OriginGame> FindAllGamesById(out string[] err
         var (games, allErrors) = FindAllGames().SplitResults();
         errors = allErrors;
 
-        return games.ToDictionary(game => game.Id, game => game, StringComparer.OrdinalIgnoreCase);
+        return games.CustomToDictionary(game => game.Id, game => game, StringComparer.OrdinalIgnoreCase);
     }
 
     private static Result ParseMfstFile(IFileInfo fileInfo)

GameFinder.StoreHandlers.Steam/SteamHandler.cs

@@ -110,7 +110,7 @@ public override Dictionary<int, SteamGame> FindAllGamesById(out string[] errors)
         var (games, allErrors) = FindAllGames().SplitResults();
         errors = allErrors;
 
-        return games.ToDictionary(game => game.AppId, game => game);
+        return games.CustomToDictionary(game => game.AppId, game => game);
     }
 
     private (IFileInfo? libraryFoldersFile, string? error) FindSteam()