Pack release builds

erri120 · Sep 3, 2023 · 46c7660 · 46c7660
1 parent bf3ce5c
commit 46c7660
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -30,7 +30,10 @@ jobs:
       run: dotnet restore
 
     - name: Pack
-      run: dotnet pack --no-restore -p:Version="${{ steps.tag_name.outputs.current_version }}" -p:RepositoryBranch=${{ github.ref_name }} -p:RepositoryCommit="${{ github.sha }}"
+      # https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#packrelease
+      env:
+        DOTNET_CLI_ENABLE_PACK_RELEASE_FOR_SOLUTIONS: true
+      run: dotnet pack -c Release --no-restore -p:Version="${{ steps.tag_name.outputs.current_version }}" -p:RepositoryBranch=${{ github.ref_name }} -p:RepositoryCommit="${{ github.sha }}"
 
     - name: Get Changelog Entry
       id: changelog_reader

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -11,6 +11,9 @@
         <RepositoryUrl>https://github.com/erri120/GameFinder.git</RepositoryUrl>
         <RepositoryType>git</RepositoryType>
 
+        <!-- https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#packrelease -->
+        <PackRelease>true</PackRelease>
+
         <IncludeSymbols>true</IncludeSymbols>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
 

diff --git a/src/GameFinder.RegistryUtils/InMemoryRegistry.cs b/src/GameFinder.RegistryUtils/InMemoryRegistry.cs
@@ -129,7 +129,7 @@ public void AddValue(string valueName, object value)
             return names.Length == 1 ? child : child.OpenSubKey(names.Skip(1).Aggregate((a, b) => $"{a}\\{b}"));
         }
 
-        // TODO: this is only a stop-gag measure
+        // TODO: this is only a stop-gap measure
         if (string.Equals(_key, "Software", StringComparison.OrdinalIgnoreCase))
         {
             if (_children.TryGetValue("Wow6432Node", out var wowNode))